diff options
author | Howard Braham <howrad@gmail.com> | 2018-09-18 11:04:10 +0800 |
---|---|---|
committer | Howard Braham <howrad@gmail.com> | 2018-10-10 06:31:25 +0800 |
commit | 222e62d7f10ffe22dd606aea9c15e1547986c4ab (patch) | |
tree | 4b3cb0d4853d9a1408dc8b28bfdf9d9abb2f2ad5 /ui/app | |
parent | db4569e920b01791edb2bab8f87dcfd9596b1837 (diff) | |
download | tangerine-wallet-browser-222e62d7f10ffe22dd606aea9c15e1547986c4ab.tar tangerine-wallet-browser-222e62d7f10ffe22dd606aea9c15e1547986c4ab.tar.gz tangerine-wallet-browser-222e62d7f10ffe22dd606aea9c15e1547986c4ab.tar.bz2 tangerine-wallet-browser-222e62d7f10ffe22dd606aea9c15e1547986c4ab.tar.lz tangerine-wallet-browser-222e62d7f10ffe22dd606aea9c15e1547986c4ab.tar.xz tangerine-wallet-browser-222e62d7f10ffe22dd606aea9c15e1547986c4ab.tar.zst tangerine-wallet-browser-222e62d7f10ffe22dd606aea9c15e1547986c4ab.zip |
Bug Fix: #1789 and #4525 eth.getCode() with no contract
Diffstat (limited to 'ui/app')
-rw-r--r-- | ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js | 2 | ||||
-rw-r--r-- | ui/app/components/send/send.utils.js | 2 | ||||
-rw-r--r-- | ui/app/constants/error-keys.js | 1 | ||||
-rw-r--r-- | ui/app/helpers/transactions.util.js | 2 |
4 files changed, 4 insertions, 3 deletions
diff --git a/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js b/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js index 707dad62d..9e6341722 100644 --- a/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js +++ b/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js @@ -131,7 +131,7 @@ export default class ConfirmTransactionBase extends Component { if (simulationFails) { return { valid: true, - errorKey: TRANSACTION_ERROR_KEY, + errorKey: simulationFails.errorKey ? simulationFails.errorKey : TRANSACTION_ERROR_KEY, } } diff --git a/ui/app/components/send/send.utils.js b/ui/app/components/send/send.utils.js index a18a9e4b3..05ba6b88f 100644 --- a/ui/app/components/send/send.utils.js +++ b/ui/app/components/send/send.utils.js @@ -215,7 +215,7 @@ async function estimateGas ({ // if recipient has no code, gas is 21k max: if (!selectedToken && !data) { const code = Boolean(to) && await global.eth.getCode(to) - if (!code || code === '0x') { + if (!code || code === '0x' || code === '0x0') { // Infura will return '0x', and Ganache will return '0x0' return SIMPLE_GAS_COST } } else if (selectedToken && !to) { diff --git a/ui/app/constants/error-keys.js b/ui/app/constants/error-keys.js index f70ed3b19..704064c96 100644 --- a/ui/app/constants/error-keys.js +++ b/ui/app/constants/error-keys.js @@ -1,3 +1,4 @@ export const INSUFFICIENT_FUNDS_ERROR_KEY = 'insufficientFunds' export const GAS_LIMIT_TOO_LOW_ERROR_KEY = 'gasLimitTooLow' export const TRANSACTION_ERROR_KEY = 'transactionError' +export const TRANSACTION_NO_CONTRACT_ERROR_KEY = 'transactionErrorNoContract' diff --git a/ui/app/helpers/transactions.util.js b/ui/app/helpers/transactions.util.js index f7d249e63..0eb7972d6 100644 --- a/ui/app/helpers/transactions.util.js +++ b/ui/app/helpers/transactions.util.js @@ -114,7 +114,7 @@ export function getLatestSubmittedTxWithNonce (transactions = [], nonce = '0x0') export async function isSmartContractAddress (address) { const code = await global.eth.getCode(address) - return code && code !== '0x' + return code && code !== '0x' && code !== '0x0'; // Infura will return '0x', and Ganache will return '0x0' } export function sumHexes (...args) { |