diff options
author | Esteban MiƱo <efmino@uc.cl> | 2018-10-20 04:20:54 +0800 |
---|---|---|
committer | Whymarrh Whitby <whymarrh.whitby@gmail.com> | 2018-10-20 04:20:54 +0800 |
commit | 7c4f98ffd6f5d7237d86cb7e1277ec44dec2db22 (patch) | |
tree | f92fceda6f27e60dac99ad3efb094f381dcec7fc /app/scripts/controllers | |
parent | ea214945cf88cef457147bd33a3017c8ea97956a (diff) | |
download | tangerine-wallet-browser-7c4f98ffd6f5d7237d86cb7e1277ec44dec2db22.tar tangerine-wallet-browser-7c4f98ffd6f5d7237d86cb7e1277ec44dec2db22.tar.gz tangerine-wallet-browser-7c4f98ffd6f5d7237d86cb7e1277ec44dec2db22.tar.bz2 tangerine-wallet-browser-7c4f98ffd6f5d7237d86cb7e1277ec44dec2db22.tar.lz tangerine-wallet-browser-7c4f98ffd6f5d7237d86cb7e1277ec44dec2db22.tar.xz tangerine-wallet-browser-7c4f98ffd6f5d7237d86cb7e1277ec44dec2db22.tar.zst tangerine-wallet-browser-7c4f98ffd6f5d7237d86cb7e1277ec44dec2db22.zip |
specific add and remove methods for frequentRpcList (#5554)
Diffstat (limited to 'app/scripts/controllers')
-rw-r--r-- | app/scripts/controllers/preferences.js | 51 |
1 files changed, 25 insertions, 26 deletions
diff --git a/app/scripts/controllers/preferences.js b/app/scripts/controllers/preferences.js index 8eb2bce0c..689506a7a 100644 --- a/app/scripts/controllers/preferences.js +++ b/app/scripts/controllers/preferences.js @@ -375,22 +375,6 @@ class PreferencesController { } /** - * Gets an updated rpc list from this.addToFrequentRpcList() and sets the `frequentRpcList` to this update list. - * - * @param {string} _url The the new rpc url to add to the updated list - * @param {bool} remove Remove selected url - * @returns {Promise<void>} Promise resolves with undefined - * - */ - updateFrequentRpcList (_url, remove = false) { - return this.addToFrequentRpcList(_url, remove) - .then((rpcList) => { - this.store.updateState({ frequentRpcList: rpcList }) - return Promise.resolve() - }) - } - - /** * Setter for the `currentAccountTab` property * * @param {string} currentAccountTab Specifies the new tab to be marked as current @@ -405,24 +389,39 @@ class PreferencesController { } /** - * Returns an updated rpcList based on the passed url and the current list. - * The returned list will have a max length of 3. If the _url currently exists it the list, it will be moved to the - * end of the list. The current list is modified and returned as a promise. + * Adds custom RPC url to state. * - * @param {string} _url The rpc url to add to the frequentRpcList. - * @param {bool} remove Remove selected url - * @returns {Promise<array>} The updated frequentRpcList. + * @param {string} url The RPC url to add to frequentRpcList. + * @returns {Promise<array>} Promise resolving to updated frequentRpcList. * */ - addToFrequentRpcList (_url, remove = false) { + addToFrequentRpcList (url) { const rpcList = this.getFrequentRpcList() - const index = rpcList.findIndex((element) => { return element === _url }) + const index = rpcList.findIndex((element) => { return element === url }) if (index !== -1) { rpcList.splice(index, 1) } - if (!remove && _url !== 'http://localhost:8545') { - rpcList.push(_url) + if (url !== 'http://localhost:8545') { + rpcList.push(url) + } + this.store.updateState({ frequentRpcList: rpcList }) + return Promise.resolve(rpcList) + } + + /** + * Removes custom RPC url from state. + * + * @param {string} url The RPC url to remove from frequentRpcList. + * @returns {Promise<array>} Promise resolving to updated frequentRpcList. + * + */ + removeFromFrequentRpcList (url) { + const rpcList = this.getFrequentRpcList() + const index = rpcList.findIndex((element) => { return element === url }) + if (index !== -1) { + rpcList.splice(index, 1) } + this.store.updateState({ frequentRpcList: rpcList }) return Promise.resolve(rpcList) } |