diff options
| author | Frankie <frankie.diamond@gmail.com> | 2019-01-18 03:10:33 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-01-18 03:10:33 +0800 |
| commit | 0ad77970762ac5389e264ce70f633dddd8d58844 (patch) | |
| tree | 4f96290fc9b98e4ba3d76fd4d7b8e9378ede12e9 /app/scripts/controllers | |
| parent | de0ac53008715803408f37108941b3f49d1be952 (diff) | |
| download | tangerine-wallet-browser-0ad77970762ac5389e264ce70f633dddd8d58844.tar tangerine-wallet-browser-0ad77970762ac5389e264ce70f633dddd8d58844.tar.gz tangerine-wallet-browser-0ad77970762ac5389e264ce70f633dddd8d58844.tar.bz2 tangerine-wallet-browser-0ad77970762ac5389e264ce70f633dddd8d58844.tar.lz tangerine-wallet-browser-0ad77970762ac5389e264ce70f633dddd8d58844.tar.xz tangerine-wallet-browser-0ad77970762ac5389e264ce70f633dddd8d58844.tar.zst tangerine-wallet-browser-0ad77970762ac5389e264ce70f633dddd8d58844.zip | |
I#5956 fix 1 (#6026)
* prevent invalid chainId's when adding cusstom rpcs
* migration 30 removes invalid chaids from preferences and networkController for custom rpcs
Diffstat (limited to 'app/scripts/controllers')
| -rw-r--r-- | app/scripts/controllers/preferences.js | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/app/scripts/controllers/preferences.js b/app/scripts/controllers/preferences.js index b21cdfb36..2faf8220b 100644 --- a/app/scripts/controllers/preferences.js +++ b/app/scripts/controllers/preferences.js @@ -408,7 +408,11 @@ class PreferencesController { rpcList.splice(index, 1) } if (url !== 'http://localhost:8545') { - rpcList.push({ rpcUrl: url, chainId, ticker, nickname }) + let checkedChainId + if (!!chainId && !Number.isNaN(parseInt(chainId))) { + checkedChainId = chainId + } + rpcList.push({ rpcUrl: url, chainId: checkedChainId, ticker, nickname }) } this.store.updateState({ frequentRpcListDetail: rpcList }) return Promise.resolve(rpcList) |