aboutsummaryrefslogtreecommitdiffstats
path: root/app/scripts/controllers/transactions.js
diff options
context:
space:
mode:
authorFrankie <frankie.diamond@gmail.com>2018-04-03 07:18:35 +0800
committerGitHub <noreply@github.com>2018-04-03 07:18:35 +0800
commitc14ec4191741c444dcf5b7c3e177c17a10374c16 (patch)
tree1b72c6ec94410c6093659a5499609d15421aff30 /app/scripts/controllers/transactions.js
parent40c3edb754ece00e125571f24e68b4584988e9c2 (diff)
parentb58ca99b61e8332afc441a1520759578b754c424 (diff)
downloadtangerine-wallet-browser-c14ec4191741c444dcf5b7c3e177c17a10374c16.tar
tangerine-wallet-browser-c14ec4191741c444dcf5b7c3e177c17a10374c16.tar.gz
tangerine-wallet-browser-c14ec4191741c444dcf5b7c3e177c17a10374c16.tar.bz2
tangerine-wallet-browser-c14ec4191741c444dcf5b7c3e177c17a10374c16.tar.lz
tangerine-wallet-browser-c14ec4191741c444dcf5b7c3e177c17a10374c16.tar.xz
tangerine-wallet-browser-c14ec4191741c444dcf5b7c3e177c17a10374c16.tar.zst
tangerine-wallet-browser-c14ec4191741c444dcf5b7c3e177c17a10374c16.zip
Merge pull request #3831 from MetaMask/i#3770
some more transaction validation bug fixes
Diffstat (limited to 'app/scripts/controllers/transactions.js')
-rw-r--r--app/scripts/controllers/transactions.js5
1 files changed, 3 insertions, 2 deletions
diff --git a/app/scripts/controllers/transactions.js b/app/scripts/controllers/transactions.js
index a18a2d2e2..31e53554d 100644
--- a/app/scripts/controllers/transactions.js
+++ b/app/scripts/controllers/transactions.js
@@ -187,12 +187,12 @@ module.exports = class TransactionController extends EventEmitter {
// validate
await this.txGasUtil.validateTxParams(txParams)
// construct txMeta
- const txMeta = this.txStateManager.generateTxMeta({txParams})
+ let txMeta = this.txStateManager.generateTxMeta({txParams})
this.addTx(txMeta)
this.emit('newUnapprovedTx', txMeta)
// add default tx params
try {
- await this.addTxDefaults(txMeta)
+ txMeta = await this.addTxDefaults(txMeta)
} catch (error) {
console.log(error)
this.txStateManager.setTxStatusFailed(txMeta.id, error)
@@ -215,6 +215,7 @@ module.exports = class TransactionController extends EventEmitter {
}
txParams.gasPrice = ethUtil.addHexPrefix(gasPrice.toString(16))
txParams.value = txParams.value || '0x0'
+ if (txParams.to === null) delete txParams.to
// set gasLimit
return await this.txGasUtil.analyzeGasUsage(txMeta)
}