Merge pull request #4766 from whymarrh/null-translations

Rework i18n-helper getMessage function

4 files changed, 18 insertions, 41 deletions

diff --git a/ui/app/components/pages/home.js b/ui/app/components/pages/home.js
index 86bd32c8a..38aa02dae 100644
--- a/ui/app/components/pages/home.js
+++ b/ui/app/components/pages/home.js
@@ -1,6 +1,6 @@
 const { Component } = require('react')
+const { connect } = require('react-redux')
 const PropTypes = require('prop-types')
-const connect = require('../../metamask-connect')
 const { Redirect, withRouter } = require('react-router-dom')
 const { compose } = require('recompose')
 const h = require('react-hyperscript')
diff --git a/ui/app/i18n-provider.js b/ui/app/i18n-provider.js
index 2856e0ed6..d46911f7c 100644
--- a/ui/app/i18n-provider.js
+++ b/ui/app/i18n-provider.js
@@ -8,8 +8,11 @@ const t = require('../i18n-helper').getMessage
 class I18nProvider extends Component {
   getChildContext () {
     const { localeMessages } = this.props
+    const { current, en } = localeMessages
     return {
-      t: t.bind(null, localeMessages),
+      t (key, ...args) {
+        return t(current, key, ...args) || t(en, key, ...args) || `[${key}]`
+      },
     }
   }
 
diff --git a/ui/app/metamask-connect.js b/ui/app/metamask-connect.js
deleted file mode 100644
index 81fa7e403..000000000
--- a/ui/app/metamask-connect.js
+++ /dev/null
@@ -1,27 +0,0 @@
-const connect = require('react-redux').connect
-const t = require('../i18n-helper').getMessage
-
-const metamaskConnect = (mapStateToProps, mapDispatchToProps) => {
-    return connect(
-        _higherOrderMapStateToProps(mapStateToProps),
-        mapDispatchToProps
-    )
-}
-
-const _higherOrderMapStateToProps = (mapStateToProps) => {
-    let _t
-    let currentLocale
-    return (state, ownProps = {}) => {
-        const stateProps = mapStateToProps
-            ? mapStateToProps(state, ownProps)
-            : ownProps
-        if (currentLocale !== state.metamask.currentLocale) {
-            currentLocale = state.metamask.currentLocale
-            _t = t.bind(null, state.localeMessages)
-        }
-        stateProps.t = _t
-        return stateProps
-    }
-}
-
-module.exports = metamaskConnect
diff --git a/ui/i18n-helper.js b/ui/i18n-helper.js
index 79aa93116..bc927ee65 100644
--- a/ui/i18n-helper.js
+++ b/ui/i18n-helper.js
@@ -1,20 +1,22 @@
 // cross-browser connection to extension i18n API
 const log = require('loglevel')
 
+/**
+ * Returns a localized message for the given key
+ * @param {object} locale The locale
+ * @param {string} key The message key
+ * @param {string[]} substitutions A list of message substitution replacements
+ * @return {null|string} The localized message
+ */
 const getMessage = (locale, key, substitutions) => {
-  // check locale is loaded
   if (!locale) {
-    // throw new Error('Translator - has not loaded a locale yet.')
-    return ''
+    return null
   }
-  // check entry is present
-  const { current, en } = locale
-  const entry = current[key] || en[key]
-  if (!entry) {
-    // throw new Error(`Translator - Unable to find value for "${key}"`)
-    log.error(`Translator - Unable to find value for "${key}"`)
-    return `[${key}]`
+  if (!locale[key]) {
+    log.error(`Translator - Unable to find value for key "${key}"`)
+    return null
   }
+  const entry = locale[key]
   let phrase = entry.message
   // perform substitutions
   if (substitutions && substitutions.length) {
@@ -29,8 +31,7 @@ const getMessage = (locale, key, substitutions) => {
 async function fetchLocale (localeName) {
   try {
     const response = await fetch(`./_locales/${localeName}/messages.json`)
-    const locale = await response.json()
-    return locale
+    return await response.json()
   } catch (error) {
     log.error(`failed to fetch ${localeName} locale because of ${error}`)
     return {}