aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkumavis <kumavis@users.noreply.github.com>2017-01-25 06:02:26 +0800
committerGitHub <noreply@github.com>2017-01-25 06:02:26 +0800
commit44d0fcf0af8b3bfd2f9c47e27c0ceb2e9b4c156c (patch)
treeea4b68bc2df79a2e9f0de5ddf36762f256872660
parent85b34e3f2b89df9e8fbacc99b7bb39de977319d5 (diff)
parent745fff0c80c49959aad9b0d214aff83cb05c3613 (diff)
downloadtangerine-wallet-browser-44d0fcf0af8b3bfd2f9c47e27c0ceb2e9b4c156c.tar
tangerine-wallet-browser-44d0fcf0af8b3bfd2f9c47e27c0ceb2e9b4c156c.tar.gz
tangerine-wallet-browser-44d0fcf0af8b3bfd2f9c47e27c0ceb2e9b4c156c.tar.bz2
tangerine-wallet-browser-44d0fcf0af8b3bfd2f9c47e27c0ceb2e9b4c156c.tar.lz
tangerine-wallet-browser-44d0fcf0af8b3bfd2f9c47e27c0ceb2e9b4c156c.tar.xz
tangerine-wallet-browser-44d0fcf0af8b3bfd2f9c47e27c0ceb2e9b4c156c.tar.zst
tangerine-wallet-browser-44d0fcf0af8b3bfd2f9c47e27c0ceb2e9b4c156c.zip
Merge pull request #1052 from MetaMask/hotfix1048
hotfix - dont assume hd keyring position
-rw-r--r--app/scripts/keyring-controller.js8
-rw-r--r--ui/app/actions.js4
2 files changed, 7 insertions, 5 deletions
diff --git a/app/scripts/keyring-controller.js b/app/scripts/keyring-controller.js
index 86c93f5a3..76422bf6b 100644
--- a/app/scripts/keyring-controller.js
+++ b/app/scripts/keyring-controller.js
@@ -259,9 +259,11 @@ module.exports = class KeyringController extends EventEmitter {
// Calls the `addAccounts` method on the Keyring
// in the kryings array at index `keyringNum`,
// and then saves those changes.
- addNewAccount (keyRingNum = 0) {
- const ring = this.keyrings[keyRingNum]
- return ring.addAccounts(1)
+ addNewAccount () {
+ const hdKeyrings = this.keyrings.filter((keyring) => keyring.type === 'HD Key Tree')
+ const firstKeyring = hdKeyrings[0]
+ if (!firstKeyring) throw new Error('KeyringController - No HD Key Tree found')
+ return firstKeyring.addAccounts(1)
.then(this.setupAccounts.bind(this))
.then(this.persistAllKeyrings.bind(this))
.then(this.fullUpdate.bind(this))
diff --git a/ui/app/actions.js b/ui/app/actions.js
index 7934a329a..9a68d231a 100644
--- a/ui/app/actions.js
+++ b/ui/app/actions.js
@@ -270,8 +270,8 @@ function navigateToNewAccountScreen() {
}
}
-function addNewAccount (ringNumber = 0) {
- return callBackgroundThenUpdate(background.addNewAccount, ringNumber)
+function addNewAccount () {
+ return callBackgroundThenUpdate(background.addNewAccount)
}
function showInfoPage () {