aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKevin Serrano <kevgagser@gmail.com>2017-07-04 06:23:40 +0800
committerGitHub <noreply@github.com>2017-07-04 06:23:40 +0800
commit27c651d8da3a9d8956c6b8a119a51a3382c449fe (patch)
tree90932fe76b0f8ce9cea93de0c068a09b60b17f55
parentfa533469cb6ddc5b5142afed2b4950565494d5a0 (diff)
parentd3c7ba31c5031f3bf004108505c41cd864438583 (diff)
downloadtangerine-wallet-browser-27c651d8da3a9d8956c6b8a119a51a3382c449fe.tar
tangerine-wallet-browser-27c651d8da3a9d8956c6b8a119a51a3382c449fe.tar.gz
tangerine-wallet-browser-27c651d8da3a9d8956c6b8a119a51a3382c449fe.tar.bz2
tangerine-wallet-browser-27c651d8da3a9d8956c6b8a119a51a3382c449fe.tar.lz
tangerine-wallet-browser-27c651d8da3a9d8956c6b8a119a51a3382c449fe.tar.xz
tangerine-wallet-browser-27c651d8da3a9d8956c6b8a119a51a3382c449fe.tar.zst
tangerine-wallet-browser-27c651d8da3a9d8956c6b8a119a51a3382c449fe.zip
Merge pull request #1729 from MetaMask/i1707-ClarifySearchingIndication
Clarify network searching indication
-rw-r--r--CHANGELOG.md3
-rw-r--r--ui/app/app.js47
-rw-r--r--ui/app/components/network.js23
3 files changed, 50 insertions, 23 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index abb8f24f5..ddaa8a049 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,9 @@
## Current Master
+- Visually indicate that network spinner is a menu.
+- Indicate what network is being searched for when disconnected.
+
## 3.8.1 2017-6-30
- Temporarily disabled loading popular tokens by default to improve performance.
diff --git a/ui/app/app.js b/ui/app/app.js
index 8bf69b5ad..8fb424786 100644
--- a/ui/app/app.js
+++ b/ui/app/app.js
@@ -68,7 +68,7 @@ App.prototype.render = function () {
const { isLoading, loadingMessage, transForward, network } = props
const isLoadingNetwork = network === 'loading'
const loadMessage = loadingMessage || isLoadingNetwork ?
- 'Searching for Network' : null
+ `Connecting to ${this.getNetworkName()}` : null
log.debug('Main ui render function')
@@ -136,7 +136,7 @@ App.prototype.renderAppBar = function () {
},
}, [
- h('div', {
+ h('div.left-menu-section', {
style: {
display: 'flex',
flexDirection: 'row',
@@ -151,21 +151,15 @@ App.prototype.renderAppBar = function () {
src: '/images/icon-128.png',
}),
- h('#network-spacer.flex-center', {
- style: {
- marginRight: '-72px',
+ h(NetworkIndicator, {
+ network: this.props.network,
+ provider: this.props.provider,
+ onClick: (event) => {
+ event.preventDefault()
+ event.stopPropagation()
+ this.setState({ isNetworkMenuOpen: !isNetworkMenuOpen })
},
- }, [
- h(NetworkIndicator, {
- network: this.props.network,
- provider: this.props.provider,
- onClick: (event) => {
- event.preventDefault()
- event.stopPropagation()
- this.setState({ isNetworkMenuOpen: !isNetworkMenuOpen })
- },
- }),
- ]),
+ }),
]),
// metamask name
@@ -555,6 +549,27 @@ App.prototype.renderCustomOption = function (provider) {
}
}
+App.prototype.getNetworkName = function () {
+ const { provider } = this.props
+ const providerName = provider.type
+
+ let name
+
+ if (providerName === 'mainnet') {
+ name = 'Main Ethereum Network'
+ } else if (providerName === 'ropsten') {
+ name = 'Ropsten Test Network'
+ } else if (providerName === 'kovan') {
+ name = 'Kovan Test Network'
+ } else if (providerName === 'rinkeby') {
+ name = 'Rinkeby Test Network'
+ } else {
+ name = 'Unknown Private Network'
+ }
+
+ return name
+}
+
App.prototype.renderCommonRpc = function (rpcList, provider) {
const { rpcTarget } = provider
const props = this.props
diff --git a/ui/app/components/network.js b/ui/app/components/network.js
index 31a8fc17c..d5d3e18cd 100644
--- a/ui/app/components/network.js
+++ b/ui/app/components/network.js
@@ -22,15 +22,24 @@ Network.prototype.render = function () {
let iconName, hoverText
if (networkNumber === 'loading') {
- return h('img.network-indicator', {
- title: 'Attempting to connect to blockchain.',
- onClick: (event) => this.props.onClick(event),
+ return h('span', {
style: {
- width: '27px',
- marginRight: '-27px',
+ display: 'flex',
+ alignItems: 'center',
+ flexDirection: 'row',
},
- src: 'images/loading.svg',
- })
+ onClick: (event) => this.props.onClick(event),
+ }, [
+ h('img', {
+ title: 'Attempting to connect to blockchain.',
+ style: {
+ width: '27px',
+ },
+ src: 'images/loading.svg',
+ }),
+ h('i.fa.fa-sort-desc'),
+ ])
+
} else if (providerName === 'mainnet') {
hoverText = 'Main Ethereum Network'
iconName = 'ethereum-network'