aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkumavis <kumavis@users.noreply.github.com>2017-01-25 07:00:46 +0800
committerGitHub <noreply@github.com>2017-01-25 07:00:46 +0800
commit23c2b0b9a5d3f222bfeba7bcff5cf5a57367ffc8 (patch)
tree546c685f6ee3f9cd7e03980a0909f54f94144b47
parent5811f2ab14f3a92eb8c92f20eb16a9b6dba35902 (diff)
parent8ed657d5d574389a1b4c44d127ecf37f86cc7e64 (diff)
downloadtangerine-wallet-browser-23c2b0b9a5d3f222bfeba7bcff5cf5a57367ffc8.tar
tangerine-wallet-browser-23c2b0b9a5d3f222bfeba7bcff5cf5a57367ffc8.tar.gz
tangerine-wallet-browser-23c2b0b9a5d3f222bfeba7bcff5cf5a57367ffc8.tar.bz2
tangerine-wallet-browser-23c2b0b9a5d3f222bfeba7bcff5cf5a57367ffc8.tar.lz
tangerine-wallet-browser-23c2b0b9a5d3f222bfeba7bcff5cf5a57367ffc8.tar.xz
tangerine-wallet-browser-23c2b0b9a5d3f222bfeba7bcff5cf5a57367ffc8.tar.zst
tangerine-wallet-browser-23c2b0b9a5d3f222bfeba7bcff5cf5a57367ffc8.zip
Merge pull request #1050 from MetaMask/fixConfTxBalanceLogic
Fix conf tx balance logic
-rw-r--r--CHANGELOG.md1
-rw-r--r--ui/app/conf-tx.js2
2 files changed, 2 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index fa825e860..cced970cb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,7 @@
## Current Master
+- Fix rendering bug where the Confirm transaction view would lets you approve transactions when the account has insufficient balance.
- Add ability to import accounts in JSON file format (used by Mist, Geth, MyEtherWallet, and more!)
## 3.1.1 2017-1-20
diff --git a/ui/app/conf-tx.js b/ui/app/conf-tx.js
index a6e03c3ed..1bd69f7d9 100644
--- a/ui/app/conf-tx.js
+++ b/ui/app/conf-tx.js
@@ -134,7 +134,7 @@ ConfirmTxScreen.prototype.checkBalanceAgainstTx = function (txData) {
var address = txData.txParams.from || state.selectedAccount
var account = state.accounts[address]
var balance = account ? account.balance : '0x0'
- var maxCost = new BN(txData.maxCost)
+ var maxCost = new BN(txData.maxCost, 16)
var balanceBn = new BN(ethUtil.stripHexPrefix(balance), 16)
return maxCost.gt(balanceBn)