core: add debug (#133)

* Split interface

* Rename nonblocking-application to nonblocking

Parts needs nonblocking gets more.

* Implement core.nonBlocking based on interface split

* Fix: the witness parent hash could be parent on compaction chain.

* Rename Application.DeliverBlock to BlockDeliver

To sync with naming of other methods.

* Change methods' fingerprint

- BlockConfirmed provides block hash only.
- BlockDeliver provde a whole block.

1 files changed, 15 insertions, 11 deletions

diff --git a/core/interfaces.go b/core/interfaces.go
index 5e1002c..03caa63 100644
--- a/core/interfaces.go
+++ b/core/interfaces.go
@@ -33,8 +33,22 @@ type Application interface {
 	// VerifyPayloads verifies if the payloads are valid.
 	VerifyPayloads(payloads []byte) bool
 
+	// BlockDeliver is called when a block is add to the compaction chain.
+	BlockDeliver(block types.Block)
+
+	// BlockProcessedChan returns a channel to receive the block hashes that have
+	// finished processing by the application.
+	BlockProcessedChan() <-chan types.WitnessResult
+
+	// WitnessAckDeliver is called when a witness ack is created.
+	WitnessAckDeliver(witnessAck *types.WitnessAck)
+}
+
+// Debug describes the application interface that requires
+// more detailed consensus execution.
+type Debug interface {
 	// BlockConfirmed is called when a block is confirmed and added to lattice.
-	BlockConfirmed(block *types.Block)
+	BlockConfirmed(blockHash common.Hash)
 
 	// StronglyAcked is called when a block is strongly acked.
 	StronglyAcked(blockHash common.Hash)
@@ -42,16 +56,6 @@ type Application interface {
 	// TotalOrderingDeliver is called when the total ordering algorithm deliver
 	// a set of block.
 	TotalOrderingDeliver(blockHashes common.Hashes, early bool)
-
-	// DeliverBlock is called when a block is add to the compaction chain.
-	DeliverBlock(blockHash common.Hash, timestamp time.Time)
-
-	// BlockProcessedChan returns a channel to receive the block hashes that have
-	// finished processing by the application.
-	BlockProcessedChan() <-chan types.WitnessResult
-
-	// WitnessAckDeliver is called when a witness ack is created.
-	WitnessAckDeliver(witnessAck *types.WitnessAck)
 }
 
 // Network describs the network interface that interacts with DEXON consensus