Do not call g_object_notify() when property didn't change

10 files changed, 63 insertions, 3 deletions

diff --git a/widgets/misc/e-attachment-bar.c b/widgets/misc/e-attachment-bar.c
index d7c90df330..ed9fb02105 100644
--- a/widgets/misc/e-attachment-bar.c
+++ b/widgets/misc/e-attachment-bar.c
@@ -759,6 +759,9 @@ e_attachment_bar_set_expanded (EAttachmentBar *bar,
 {
 	g_return_if_fail (E_IS_ATTACHMENT_BAR (bar));
 
+	if ((bar->priv->expanded ? 1 : 0) == (expanded ? 1 : 0))
+		return;
+
 	bar->priv->expanded = expanded;
 
 	g_object_notify (G_OBJECT (bar), "expanded");
diff --git a/widgets/misc/e-attachment-button.c b/widgets/misc/e-attachment-button.c
index d3aa4a6350..d3fda0985a 100644
--- a/widgets/misc/e-attachment-button.c
+++ b/widgets/misc/e-attachment-button.c
@@ -834,6 +834,9 @@ e_attachment_button_set_expandable (EAttachmentButton *button,
 {
 	g_return_if_fail (E_IS_ATTACHMENT_BUTTON (button));
 
+	if ((button->priv->expandable ? 1 : 0) == (expandable ? 1 : 0))
+		return;
+
 	button->priv->expandable = expandable;
 
 	if (!expandable)
@@ -856,6 +859,9 @@ e_attachment_button_set_expanded (EAttachmentButton *button,
 {
 	g_return_if_fail (E_IS_ATTACHMENT_BUTTON (button));
 
+	if ((button->priv->expanded ? 1 : 0) == (expanded ? 1 : 0))
+		return;
+
 	button->priv->expanded = expanded;
 
 	g_object_notify (G_OBJECT (button), "expanded");
diff --git a/widgets/misc/e-attachment-paned.c b/widgets/misc/e-attachment-paned.c
index c0048fcd31..119c66e6f2 100644
--- a/widgets/misc/e-attachment-paned.c
+++ b/widgets/misc/e-attachment-paned.c
@@ -843,6 +843,9 @@ e_attachment_paned_set_expanded (EAttachmentPaned *paned,
 {
 	g_return_if_fail (E_IS_ATTACHMENT_PANED (paned));
 
+	if ((paned->priv->expanded ? 1 : 0) == (expanded ? 1 : 0))
+		return;
+
 	paned->priv->expanded = expanded;
 
 	g_object_notify (G_OBJECT (paned), "expanded");
@@ -862,6 +865,9 @@ e_attachment_paned_set_resize_toplevel (EAttachmentPaned *paned,
 {
 	g_return_if_fail (E_IS_ATTACHMENT_PANED (paned));
 
+	if ((paned->priv->resize_toplevel ? 1 : 0) == (resize_toplevel ? 1 : 0))
+		return;
+
 	paned->priv->resize_toplevel = resize_toplevel;
 
 	g_object_notify (G_OBJECT (paned), "resize-toplevel");
diff --git a/widgets/misc/e-dateedit.c b/widgets/misc/e-dateedit.c
index 38b1900e03..60b6b42d35 100644
--- a/widgets/misc/e-dateedit.c
+++ b/widgets/misc/e-dateedit.c
@@ -1050,7 +1050,7 @@ e_date_edit_set_show_date (EDateEdit *dedit,
 
 	priv = dedit->priv;
 
-	if (priv->show_date == show_date)
+	if ((priv->show_date ? 1 : 0) == (show_date ? 1 : 0))
 		return;
 
 	priv->show_date = show_date;
@@ -1107,7 +1107,7 @@ e_date_edit_set_show_time (EDateEdit *dedit,
 
 	priv = dedit->priv;
 
-	if (priv->show_time == show_time)
+	if ((priv->show_time ? 1 : 0) == (show_time ? 1 : 0))
 		return;
 
 	priv->show_time = show_time;
@@ -1250,7 +1250,7 @@ e_date_edit_set_use_24_hour_format (EDateEdit *dedit,
 {
 	g_return_if_fail (E_IS_DATE_EDIT (dedit));
 
-	if (dedit->priv->use_24_hour_format == use_24_hour_format)
+	if ((dedit->priv->use_24_hour_format ? 1 : 0) == (use_24_hour_format ? 1 : 0))
 		return;
 
 	dedit->priv->use_24_hour_format = use_24_hour_format;
@@ -1278,6 +1278,9 @@ e_date_edit_set_allow_no_date_set (EDateEdit *dedit,
 {
 	g_return_if_fail (E_IS_DATE_EDIT (dedit));
 
+	if ((dedit->priv->allow_no_date_set ? 1 : 0) == (allow_no_date_set ? 1 : 0))
+		return;
+
 	dedit->priv->allow_no_date_set = allow_no_date_set;
 
 	if (!allow_no_date_set) {
diff --git a/widgets/misc/e-mail-signature-combo-box.c b/widgets/misc/e-mail-signature-combo-box.c
index 40f0d77744..d7a7039344 100644
--- a/widgets/misc/e-mail-signature-combo-box.c
+++ b/widgets/misc/e-mail-signature-combo-box.c
@@ -381,6 +381,9 @@ e_mail_signature_combo_box_set_identity_uid (EMailSignatureComboBox *combo_box,
 
 	g_return_if_fail (E_IS_MAIL_SIGNATURE_COMBO_BOX (combo_box));
 
+	if (g_strcmp0 (combo_box->priv->identity_uid, identity_uid) == 0)
+		return;
+
 	g_free (combo_box->priv->identity_uid);
 	combo_box->priv->identity_uid = g_strdup (identity_uid);
 
diff --git a/widgets/misc/e-mail-signature-manager.c b/widgets/misc/e-mail-signature-manager.c
index 0392316756..425fbca33a 100644
--- a/widgets/misc/e-mail-signature-manager.c
+++ b/widgets/misc/e-mail-signature-manager.c
@@ -690,6 +690,9 @@ e_mail_signature_manager_set_prefer_html (EMailSignatureManager *manager,
 {
 	g_return_if_fail (E_IS_MAIL_SIGNATURE_MANAGER (manager));
 
+	if ((manager->priv->prefer_html ? 1 : 0) == (prefer_html ? 1 : 0))
+		return;
+
 	manager->priv->prefer_html = prefer_html;
 
 	g_object_notify (G_OBJECT (manager), "prefer-html");
diff --git a/widgets/misc/e-online-button.c b/widgets/misc/e-online-button.c
index 07ff998dc3..41b81f4b94 100644
--- a/widgets/misc/e-online-button.c
+++ b/widgets/misc/e-online-button.c
@@ -190,6 +190,9 @@ e_online_button_set_online (EOnlineButton *button,
 
 	g_return_if_fail (E_IS_ONLINE_BUTTON (button));
 
+	if ((button->priv->online ? 1 : 0) == (online ? 1 : 0))
+		return;
+
 	button->priv->online = online;
 
 	image = GTK_IMAGE (button->priv->image);
diff --git a/widgets/misc/e-popup-action.c b/widgets/misc/e-popup-action.c
index 2fd000ccad..f5d8445d77 100644
--- a/widgets/misc/e-popup-action.c
+++ b/widgets/misc/e-popup-action.c
@@ -139,6 +139,9 @@ popup_action_set_use_action_appearance (EPopupAction *popup_action,
 	GtkActivatable *activatable;
 	GtkAction *related_action;
 
+	if ((popup_action->priv->use_action_appearance ? 1 : 0) == (use_action_appearance ? 1 : 0))
+		return;
+
 	popup_action->priv->use_action_appearance = use_action_appearance;
 
 	g_object_notify (G_OBJECT (popup_action), "use-action-appearance");
diff --git a/widgets/misc/e-port-entry.c b/widgets/misc/e-port-entry.c
index cf857b5d55..f007731433 100644
--- a/widgets/misc/e-port-entry.c
+++ b/widgets/misc/e-port-entry.c
@@ -468,6 +468,9 @@ e_port_entry_set_security_method (EPortEntry *port_entry,
 {
 	g_return_if_fail (E_IS_PORT_ENTRY (port_entry));
 
+	if (port_entry->priv->method == method)
+		return;
+
 	port_entry->priv->method = method;
 
 	port_entry_method_changed (port_entry);
diff --git a/widgets/misc/e-web-view.c b/widgets/misc/e-web-view.c
index 9cf4f669dd..8ace48ca1d 100644
--- a/widgets/misc/e-web-view.c
+++ b/widgets/misc/e-web-view.c
@@ -2205,6 +2205,9 @@ e_web_view_set_caret_mode (EWebView *web_view,
 {
 	g_return_if_fail (E_IS_WEB_VIEW (web_view));
 
+	if ((web_view->priv->caret_mode ? 1 : 0) == (caret_mode ? 1 : 0))
+		return;
+
 	web_view->priv->caret_mode = caret_mode;
 
 	g_object_notify (G_OBJECT (web_view), "caret-mode");
@@ -2233,6 +2236,9 @@ e_web_view_set_disable_printing (EWebView *web_view,
 {
 	g_return_if_fail (E_IS_WEB_VIEW (web_view));
 
+	if ((web_view->priv->disable_printing ? 1 : 0) == (disable_printing ? 1 : 0))
+		return;
+
 	web_view->priv->disable_printing = disable_printing;
 
 	g_object_notify (G_OBJECT (web_view), "disable-printing");
@@ -2252,6 +2258,9 @@ e_web_view_set_disable_save_to_disk (EWebView *web_view,
 {
 	g_return_if_fail (E_IS_WEB_VIEW (web_view));
 
+	if ((web_view->priv->disable_save_to_disk ? 1 : 0) == (disable_save_to_disk ? 1 : 0))
+		return;
+
 	web_view->priv->disable_save_to_disk = disable_save_to_disk;
 
 	g_object_notify (G_OBJECT (web_view), "disable-save-to-disk");
@@ -2416,6 +2425,9 @@ e_web_view_set_selected_uri (EWebView *web_view,
 {
 	g_return_if_fail (E_IS_WEB_VIEW (web_view));
 
+	if (g_strcmp0 (web_view->priv->selected_uri, selected_uri) == 0)
+		return;
+
 	g_free (web_view->priv->selected_uri);
 	web_view->priv->selected_uri = g_strdup (selected_uri);
 
@@ -2436,6 +2448,9 @@ e_web_view_set_cursor_image (EWebView *web_view,
 {
 	g_return_if_fail (E_IS_WEB_VIEW (web_view));
 
+	if (web_view->priv->cursor_image == image)
+		return;
+
 	if (image != NULL)
 		g_object_ref (image);
 
@@ -2461,6 +2476,9 @@ e_web_view_set_cursor_image_src (EWebView *web_view,
 {
 	g_return_if_fail (E_IS_WEB_VIEW (web_view));
 
+	if (g_strcmp0 (web_view->priv->cursor_image_src, src_uri) == 0)
+		return;
+
 	g_free (web_view->priv->cursor_image_src);
 	web_view->priv->cursor_image_src = g_strdup (src_uri);
 
@@ -2481,6 +2499,9 @@ e_web_view_set_open_proxy (EWebView *web_view,
 {
 	g_return_if_fail (E_IS_WEB_VIEW (web_view));
 
+	if (web_view->priv->open_proxy == open_proxy)
+		return;
+
 	if (open_proxy != NULL) {
 		g_return_if_fail (GTK_IS_ACTION (open_proxy));
 		g_object_ref (open_proxy);
@@ -2517,6 +2538,9 @@ e_web_view_set_print_proxy (EWebView *web_view,
 {
 	g_return_if_fail (E_IS_WEB_VIEW (web_view));
 
+	if (web_view->priv->print_proxy == print_proxy)
+		return;
+
 	if (print_proxy != NULL) {
 		g_return_if_fail (GTK_IS_ACTION (print_proxy));
 		g_object_ref (print_proxy);
@@ -2544,6 +2568,9 @@ e_web_view_set_save_as_proxy (EWebView *web_view,
 {
 	g_return_if_fail (E_IS_WEB_VIEW (web_view));
 
+	if (web_view->priv->save_as_proxy == save_as_proxy)
+		return;
+
 	if (save_as_proxy != NULL) {
 		g_return_if_fail (GTK_IS_ACTION (save_as_proxy));
 		g_object_ref (save_as_proxy);