Bug #590245 - 'evolution --force-shutdown' should kill factories

2 files changed, 73 insertions, 12 deletions

diff --git a/shell/killev.c b/shell/killev.c
index 16849eec42..948523dccb 100644
--- a/shell/killev.c
+++ b/shell/killev.c
@@ -94,6 +94,18 @@ exit:
 	return success;
 }
 
+static void
+kill_factories (void)
+{
+	#ifdef KILL_PROCESS_CMD
+
+	system (KILL_PROCESS_CMD " -QUIT evolution 2> /dev/null");
+	system (KILL_PROCESS_CMD " -QUIT e-calendar-factory 2> /dev/null");
+	system (KILL_PROCESS_CMD " -QUIT e-addressbook-factory 2> /dev/null");
+
+	#endif
+}
+
 gint
 main (gint argc, gchar **argv)
 {
@@ -116,17 +128,27 @@ main (gint argc, gchar **argv)
 
 	if (!get_evolution_pid (pid_file)) {
 		g_printerr ("Could not find Evolution's process ID\n");
+		kill_factories ();
 		exit (EXIT_FAILURE);
 	}
 
-	/* Play it safe here and bail if something goes wrong.  We don't
-	 * want to just skip to the killing if we can't ask Evolution to
-	 * terminate gracefully.  Despite our name we actually want to
-	 * -avoid- killing Evolution if at all possible. */
-	if (!g_spawn_command_line_async ("evolution --quit", &error)) {
-		g_printerr ("%s", error->message);
-		g_error_free (error);
-		exit (EXIT_FAILURE);
+	if (g_getenv ("DISPLAY") == NULL) {
+		#ifdef KILL_PROCESS_CMD
+
+		system (KILL_PROCESS_CMD " -QUIT evolution 2> /dev/null");
+
+		#endif
+	} else {
+		/* Play it safe here and bail if something goes wrong.  We don't
+		 * want to just skip to the killing if we can't ask Evolution to
+		 * terminate gracefully.  Despite our name we actually want to
+		 * -avoid- killing Evolution if at all possible. */
+		if (!g_spawn_command_line_async ("evolution --quit", &error)) {
+			g_printerr ("%s", error->message);
+			g_error_free (error);
+			kill_factories ();
+			exit (EXIT_FAILURE);
+		}
 	}
 
 	/* Now we set up a monitor on Evolution's .running file.
@@ -136,6 +158,7 @@ main (gint argc, gchar **argv)
 	if (error != NULL) {
 		g_printerr ("%s", error->message);
 		g_error_free (error);
+		kill_factories ();
 		exit (EXIT_FAILURE);
 	}
 
@@ -155,5 +178,7 @@ main (gint argc, gchar **argv)
 
 	g_object_unref (monitor);
 
+	kill_factories ();
+
 	return EXIT_SUCCESS;
 }
diff --git a/shell/main.c b/shell/main.c
index b80283b6db..da7a235a0a 100644
--- a/shell/main.c
+++ b/shell/main.c
@@ -317,8 +317,36 @@ setup_segv_redirect (void)
 	g_static_mutex_lock (&segv_mutex);
 }
 
+static void
+quit_signal (gint sig)
+{
+	EShell *shell;
+
+	g_return_if_fail (sig == SIGQUIT);
+
+	g_print ("Received quit signal...\n");
+
+	shell = e_shell_get_default ();
+	if (shell)
+		e_shell_quit (shell, E_SHELL_QUIT_OPTION);
+}
+
+static void
+setup_quit_signal (void)
+{
+	struct sigaction sa, osa;
+
+	sigaction (SIGQUIT, NULL, &osa);
+
+	sa.sa_flags = 0;
+	sigemptyset (&sa.sa_mask);
+	sa.sa_handler = quit_signal;
+	sigaction (SIGQUIT, &sa, NULL);
+}
+
 #else
 #define setup_segv_redirect() (void)0
+#define setup_quit_signal() (void)0
 #endif
 
 static GOptionEntry entries[] = {
@@ -512,6 +540,17 @@ main (gint argc, gchar **argv)
 	bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8");
 	textdomain (GETTEXT_PACKAGE);
 
+	g_type_init ();
+	if (!g_thread_get_initialized ())
+		g_thread_init (NULL);
+
+	/* do not require Gtk+ for --force-shutdown */
+	if (argc == 2 && argv[1] && g_str_equal (argv[1], "--force-shutdown")) {
+		shell_force_shutdown ();
+
+		return 0;
+	}
+
 #if HAVE_CLUTTER
 	gtk_clutter_init_with_args (
 		&argc, &argv,
@@ -532,10 +571,6 @@ main (gint argc, gchar **argv)
 		exit (1);
 	}
 
-	g_type_init ();
-	if (!g_thread_get_initialized ())
-		g_thread_init (NULL);
-
 	#ifdef HAVE_ICAL_UNKNOWN_TOKEN_HANDLING
 	ical_set_unknown_token_handling_setting (ICAL_DISCARD_TOKEN);
 	#endif
@@ -623,6 +658,7 @@ main (gint argc, gchar **argv)
 	}
 
 	setup_segv_redirect ();
+	setup_quit_signal ();
 
 	if (evolution_debug_log) {
 		gint fd;