diff options
| author | Milan Crha <mcrha@redhat.com> | 2013-11-15 16:06:57 +0800 |
|---|---|---|
| committer | Milan Crha <mcrha@redhat.com> | 2013-11-15 16:06:57 +0800 |
| commit | 570c6374806d0f1ec59cf7a72543efe6b5b637be (patch) | |
| tree | c5390b1fcb73f30c28bf37168add9bf1dc622b42 /shell/killev.c | |
| parent | 1be51f232560f864ba8795a38e55d472b5b0e2b3 (diff) | |
| download | gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.gz gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.bz2 gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.lz gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.xz gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.zst gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.zip | |
Fix/mute issues found by Coverity scan
This makes the code free of Coverity scan issues.
It is sometimes quite pedantic and expects/suggests some
coding habits, thus certain changes may look weird, but for a good
thing, I hope. The code is also tagged with Coverity scan
suppressions, to keep the code as is and hide the warning too.
Also note that Coverity treats g_return_if_fail(), g_assert() and
similar macros as unreliable, and it's true these can be disabled
during the compile time, thus it brings in other set of 'weird'
changes.
Diffstat (limited to 'shell/killev.c')
| -rw-r--r-- | shell/killev.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/shell/killev.c b/shell/killev.c index ea4ad2a8ce..2157cdbce8 100644 --- a/shell/killev.c +++ b/shell/killev.c @@ -163,7 +163,8 @@ main (gint argc, kill: #ifdef KILL_PROCESS_CMD - system (KILL_PROCESS_CMD " -QUIT evolution 2> /dev/null"); + if (system (KILL_PROCESS_CMD " -QUIT evolution 2> /dev/null") == -1) + g_warning ("%s: Failed to execute: '%s'", G_STRFUNC, KILL_PROCESS_CMD); #else g_printerr ("No \"kill\" command available.\n"); #endif |