From 570c6374806d0f1ec59cf7a72543efe6b5b637be Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Fri, 15 Nov 2013 09:06:57 +0100 Subject: Fix/mute issues found by Coverity scan This makes the code free of Coverity scan issues. It is sometimes quite pedantic and expects/suggests some coding habits, thus certain changes may look weird, but for a good thing, I hope. The code is also tagged with Coverity scan suppressions, to keep the code as is and hide the warning too. Also note that Coverity treats g_return_if_fail(), g_assert() and similar macros as unreliable, and it's true these can be disabled during the compile time, thus it brings in other set of 'weird' changes. --- shell/killev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'shell/killev.c') diff --git a/shell/killev.c b/shell/killev.c index ea4ad2a8ce..2157cdbce8 100644 --- a/shell/killev.c +++ b/shell/killev.c @@ -163,7 +163,8 @@ main (gint argc, kill: #ifdef KILL_PROCESS_CMD - system (KILL_PROCESS_CMD " -QUIT evolution 2> /dev/null"); + if (system (KILL_PROCESS_CMD " -QUIT evolution 2> /dev/null") == -1) + g_warning ("%s: Failed to execute: '%s'", G_STRFUNC, KILL_PROCESS_CMD); #else g_printerr ("No \"kill\" command available.\n"); #endif -- cgit v1.2.3