diff options
| author | Milan Crha <mcrha@redhat.com> | 2013-11-15 16:06:57 +0800 |
|---|---|---|
| committer | Milan Crha <mcrha@redhat.com> | 2013-11-15 16:06:57 +0800 |
| commit | 570c6374806d0f1ec59cf7a72543efe6b5b637be (patch) | |
| tree | c5390b1fcb73f30c28bf37168add9bf1dc622b42 /plugins/mailing-list-actions | |
| parent | 1be51f232560f864ba8795a38e55d472b5b0e2b3 (diff) | |
| download | gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.gz gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.bz2 gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.lz gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.xz gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.zst gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.zip | |
Fix/mute issues found by Coverity scan
This makes the code free of Coverity scan issues.
It is sometimes quite pedantic and expects/suggests some
coding habits, thus certain changes may look weird, but for a good
thing, I hope. The code is also tagged with Coverity scan
suppressions, to keep the code as is and hide the warning too.
Also note that Coverity treats g_return_if_fail(), g_assert() and
similar macros as unreliable, and it's true these can be disabled
during the compile time, thus it brings in other set of 'weird'
changes.
Diffstat (limited to 'plugins/mailing-list-actions')
| -rw-r--r-- | plugins/mailing-list-actions/mailing-list-actions.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/plugins/mailing-list-actions/mailing-list-actions.c b/plugins/mailing-list-actions/mailing-list-actions.c index d9466013c2..35a379c771 100644 --- a/plugins/mailing-list-actions/mailing-list-actions.c +++ b/plugins/mailing-list-actions/mailing-list-actions.c @@ -229,7 +229,7 @@ emla_list_action_cb (CamelFolder *folder, /* get URL portion */ url = g_strndup (headerpos, end - headerpos); - if (strncmp (url, "mailto:", 6) == 0) { + if (url && strncmp (url, "mailto:", 6) == 0) { if (emla_action_headers[t].interactive) send_message_response = GTK_RESPONSE_NO; else @@ -253,7 +253,7 @@ emla_list_action_cb (CamelFolder *folder, } goto exit; - } else { + } else if (url && *url) { e_show_uri (window, url); goto exit; } |