aboutsummaryrefslogtreecommitdiffstats
path: root/modules/itip-formatter
diff options
context:
space:
mode:
authorMatthew Barnes <mbarnes@redhat.com>2012-12-08 05:30:18 +0800
committerMatthew Barnes <mbarnes@redhat.com>2012-12-08 06:40:28 +0800
commitbf30024dd7973006bf99d0ae509a7f0022368a41 (patch)
treed6ce797885082ba6ee3878db5054bdbaa6d691f4 /modules/itip-formatter
parent7c656866a2a3cf9110a8db5d57a156638c8c3fe0 (diff)
downloadgsoc2013-evolution-bf30024dd7973006bf99d0ae509a7f0022368a41.tar
gsoc2013-evolution-bf30024dd7973006bf99d0ae509a7f0022368a41.tar.gz
gsoc2013-evolution-bf30024dd7973006bf99d0ae509a7f0022368a41.tar.bz2
gsoc2013-evolution-bf30024dd7973006bf99d0ae509a7f0022368a41.tar.lz
gsoc2013-evolution-bf30024dd7973006bf99d0ae509a7f0022368a41.tar.xz
gsoc2013-evolution-bf30024dd7973006bf99d0ae509a7f0022368a41.tar.zst
gsoc2013-evolution-bf30024dd7973006bf99d0ae509a7f0022368a41.zip
Teach EMailExtensionRegistry to find extensions.
Now we have the following extension points in the GType hierarchy: E_TYPE_MAIL_FORMATTER_EXTENSION E_TYPE_MAIL_FORMATTER_PRINT_EXTENSION E_TYPE_MAIL_FORMATTER_QUOTE_EXTENSION E_TYPE_MAIL_PARSER_EXTENSION A registry just needs to be given one of these extension points, and it can use g_type_children() to find and load all registered extensions. This eliminates e-mail-format-extensions.[ch] as well as the dynamic loaders I added a few commits back. Dynamically loaded extensions are now easier to register, at the cost of internal extensions being a tad more cumbersome to register. Fair tradeoff, imo. This also makes e_mail_extension_registry_add_extension() a private function used only by e_mail_formatter_extension_registry_load() and e_mail_parser_extension_registry_load().
Diffstat (limited to 'modules/itip-formatter')
-rw-r--r--modules/itip-formatter/e-mail-formatter-itip.c43
-rw-r--r--modules/itip-formatter/e-mail-parser-itip.c41
2 files changed, 0 insertions, 84 deletions
diff --git a/modules/itip-formatter/e-mail-formatter-itip.c b/modules/itip-formatter/e-mail-formatter-itip.c
index 86132f4f7b..ca2a0c6f24 100644
--- a/modules/itip-formatter/e-mail-formatter-itip.c
+++ b/modules/itip-formatter/e-mail-formatter-itip.c
@@ -37,9 +37,6 @@
typedef EMailFormatterExtension EMailFormatterItip;
typedef EMailFormatterExtensionClass EMailFormatterItipClass;
-typedef EExtension EMailFormatterItipLoader;
-typedef EExtensionClass EMailFormatterItipLoaderClass;
-
GType e_mail_formatter_itip_get_type (void);
GType e_mail_formatter_itip_loader_get_type (void);
@@ -48,11 +45,6 @@ G_DEFINE_DYNAMIC_TYPE (
e_mail_formatter_itip,
E_TYPE_MAIL_FORMATTER_EXTENSION)
-G_DEFINE_DYNAMIC_TYPE (
- EMailFormatterItipLoader,
- e_mail_formatter_itip_loader,
- E_TYPE_EXTENSION)
-
static const gchar *formatter_mime_types[] = {
"text/calendar",
"application/ics",
@@ -155,43 +147,8 @@ e_mail_formatter_itip_init (EMailFormatterExtension *extension)
{
}
-static void
-mail_formatter_itip_loader_constructed (GObject *object)
-{
- EExtensible *extensible;
-
- extensible = e_extension_get_extensible (E_EXTENSION (object));
-
- e_mail_extension_registry_add_extension (
- E_MAIL_EXTENSION_REGISTRY (extensible),
- formatter_mime_types,
- e_mail_formatter_itip_get_type ());
-}
-
-static void
-e_mail_formatter_itip_loader_class_init (EExtensionClass *class)
-{
- GObjectClass *object_class;
-
- object_class = G_OBJECT_CLASS (class);
- object_class->constructed = mail_formatter_itip_loader_constructed;
-
- class->extensible_type = E_TYPE_MAIL_FORMATTER_EXTENSION_REGISTRY;
-}
-
-static void
-e_mail_formatter_itip_loader_class_finalize (EExtensionClass *class)
-{
-}
-
-static void
-e_mail_formatter_itip_loader_init (EExtension *extension)
-{
-}
-
void
e_mail_formatter_itip_type_register (GTypeModule *type_module)
{
e_mail_formatter_itip_register_type (type_module);
- e_mail_formatter_itip_loader_register_type (type_module);
}
diff --git a/modules/itip-formatter/e-mail-parser-itip.c b/modules/itip-formatter/e-mail-parser-itip.c
index 554d863957..d0ab563dcc 100644
--- a/modules/itip-formatter/e-mail-parser-itip.c
+++ b/modules/itip-formatter/e-mail-parser-itip.c
@@ -51,18 +51,12 @@ typedef EExtension EMailParserItipLoader;
typedef EExtensionClass EMailParserItipLoaderClass;
GType e_mail_parser_itip_get_type (void);
-GType e_mail_parser_itip_loader_get_type (void);
G_DEFINE_DYNAMIC_TYPE (
EMailParserItip,
e_mail_parser_itip,
E_TYPE_MAIL_PARSER_EXTENSION)
-G_DEFINE_DYNAMIC_TYPE (
- EMailParserItipLoader,
- e_mail_parser_itip_loader,
- E_TYPE_EXTENSION)
-
static const gchar *parser_mime_types[] = {
"text/calendar",
"application/ics",
@@ -266,44 +260,9 @@ e_mail_parser_itip_init (EMailParserExtension *class)
{
}
-static void
-mail_parser_itip_loader_constructed (GObject *object)
-{
- EExtensible *extensible;
-
- extensible = e_extension_get_extensible (E_EXTENSION (object));
-
- e_mail_extension_registry_add_extension (
- E_MAIL_EXTENSION_REGISTRY (extensible),
- parser_mime_types,
- e_mail_parser_itip_get_type ());
-}
-
-static void
-e_mail_parser_itip_loader_class_init (EExtensionClass *class)
-{
- GObjectClass *object_class;
-
- object_class = G_OBJECT_CLASS (class);
- object_class->constructed = mail_parser_itip_loader_constructed;
-
- class->extensible_type = E_TYPE_MAIL_PARSER_EXTENSION_REGISTRY;
-}
-
-static void
-e_mail_parser_itip_loader_class_finalize (EExtensionClass *class)
-{
-}
-
-static void
-e_mail_parser_itip_loader_init (EExtension *extension)
-{
-}
-
void
e_mail_parser_itip_type_register (GTypeModule *type_module)
{
e_mail_parser_itip_register_type (type_module);
- e_mail_parser_itip_loader_register_type (type_module);
}