Fix/mute issues found by Coverity scan

This makes the code free of Coverity scan issues.
It is sometimes quite pedantic and expects/suggests some
coding habits, thus certain changes may look weird, but for a good
thing, I hope. The code is also tagged with Coverity scan
suppressions, to keep the code as is and hide the warning too.
Also note that Coverity treats g_return_if_fail(), g_assert() and
similar macros as unreliable, and it's true these can be disabled
during the compile time, thus it brings in other set of 'weird'
changes.

1 files changed, 1 insertions, 6 deletions

diff --git a/calendar/gui/e-cal-model.c b/calendar/gui/e-cal-model.c
index 5748e23d78..a4f06efac5 100644
--- a/calendar/gui/e-cal-model.c
+++ b/calendar/gui/e-cal-model.c
@@ -2108,12 +2108,7 @@ e_cal_model_update_comp_time (ECalModel *model,
 
 		/* If the TZID is set to "UTC", we don't want to save the TZID. */
 		if (tzid && strcmp (tzid, "UTC")) {
-			if (param) {
-				icalparameter_set_tzid (param, (gchar *) tzid);
-			} else {
-				param = icalparameter_new_tzid ((gchar *) tzid);
-				icalproperty_add_parameter (prop, param);
-			}
+			icalparameter_set_tzid (param, (gchar *) tzid);
 		} else {
 			icalproperty_remove_parameter (prop, ICAL_TZID_PARAMETER);
 		}