diff options
author | Rodney Dawes <dobey@novell.com> | 2004-07-03 00:38:18 +0800 |
---|---|---|
committer | Rodney Dawes <dobey@src.gnome.org> | 2004-07-03 00:38:18 +0800 |
commit | 0a69a49fc37b671f94645216a519801d16aa83c7 (patch) | |
tree | 917ad2d94c4eb4a599e169545736a2d172194647 | |
parent | 4f74bf09a94e4f503c38e56ad1a5aba507e05d9e (diff) | |
download | gsoc2013-evolution-0a69a49fc37b671f94645216a519801d16aa83c7.tar gsoc2013-evolution-0a69a49fc37b671f94645216a519801d16aa83c7.tar.gz gsoc2013-evolution-0a69a49fc37b671f94645216a519801d16aa83c7.tar.bz2 gsoc2013-evolution-0a69a49fc37b671f94645216a519801d16aa83c7.tar.lz gsoc2013-evolution-0a69a49fc37b671f94645216a519801d16aa83c7.tar.xz gsoc2013-evolution-0a69a49fc37b671f94645216a519801d16aa83c7.tar.zst gsoc2013-evolution-0a69a49fc37b671f94645216a519801d16aa83c7.zip |
Get the label for the calendar list header also (init_widgets): Set the
2004-07-02 Rodney Dawes <dobey@novell.com>
* gui/dialogs/url-editor-dialog.c (get_widgets):
Get the label for the calendar list header also
(init_widgets): Set the border widths for the dialog's vbox and
action area to be more compliant with the HIG
Set the mnemonic widget for the calendar label, to the Source Selector
Remove the unneeded settings for the scrolled window, these are in the
glade xml for the widget
Set the icon list on the correct dialog widget, not the settings dialog
* gui/dialogs/url-editor-dialog.h:
Add the calendar_list_label widget here so we can access it
* gui/dialogs/url-editor-dialog.glade:
Change the dialog's layout to be HIG compliant and fix some strings
to do the same
Add mnemonics to all the labels that are associated with widgets
svn path=/trunk/; revision=26564
-rw-r--r-- | calendar/ChangeLog | 19 | ||||
-rw-r--r-- | calendar/gui/dialogs/url-editor-dialog.c | 16 | ||||
-rw-r--r-- | calendar/gui/dialogs/url-editor-dialog.glade | 400 | ||||
-rw-r--r-- | calendar/gui/dialogs/url-editor-dialog.h | 1 |
4 files changed, 255 insertions, 181 deletions
diff --git a/calendar/ChangeLog b/calendar/ChangeLog index 036b8a1caf..43dca27fa5 100644 --- a/calendar/ChangeLog +++ b/calendar/ChangeLog @@ -1,3 +1,22 @@ +2004-07-02 Rodney Dawes <dobey@novell.com> + + * gui/dialogs/url-editor-dialog.c (get_widgets): + Get the label for the calendar list header also + (init_widgets): Set the border widths for the dialog's vbox and + action area to be more compliant with the HIG + Set the mnemonic widget for the calendar label, to the Source Selector + Remove the unneeded settings for the scrolled window, these are in the + glade xml for the widget + Set the icon list on the correct dialog widget, not the settings dialog + + * gui/dialogs/url-editor-dialog.h: + Add the calendar_list_label widget here so we can access it + + * gui/dialogs/url-editor-dialog.glade: + Change the dialog's layout to be HIG compliant and fix some strings + to do the same + Add mnemonics to all the labels that are associated with widgets + 2004-06-29 Sivaiah Nallagatla <snallagatla@novell.com> * gui/e-tasks.c (e_tasks_add_todo_source) diff --git a/calendar/gui/dialogs/url-editor-dialog.c b/calendar/gui/dialogs/url-editor-dialog.c index f937170f95..a6972e4ef3 100644 --- a/calendar/gui/dialogs/url-editor-dialog.c +++ b/calendar/gui/dialogs/url-editor-dialog.c @@ -161,6 +161,7 @@ get_widgets (UrlDialogData *data) #define GW(name) glade_xml_get_widget (data->xml, name) data->url_editor = GW ("url_editor"); + data->calendar_list_label = GW ("calendar_list_label"); data->url_dialog = GW ("fb_dialog"); data->url_entry = GTK_ENTRY (GW ("url_entry")); data->daily = GW ("daily"); @@ -176,6 +177,7 @@ get_widgets (UrlDialogData *data) #undef GW return (data ->url_editor + && data->calendar_list_label && data->url_entry && data->daily && data->weekly @@ -221,6 +223,10 @@ init_widgets (UrlDialogData *url_dlg_data) GList *icon_list; GSList *p; + gtk_widget_ensure_style (url_dlg_data->url_editor); + gtk_container_set_border_width (GTK_CONTAINER (GTK_DIALOG (url_dlg_data->url_editor)->vbox), 0); + gtk_container_set_border_width (GTK_CONTAINER (GTK_DIALOG (url_dlg_data->url_editor)->action_area), 12); + g_signal_connect (url_dlg_data->url_entry, "changed", G_CALLBACK (url_editor_dialog_fb_url_changed), url_dlg_data); @@ -280,17 +286,15 @@ init_widgets (UrlDialogData *url_dlg_data) G_CALLBACK (selection_changed_callback), url_dlg_data); + gtk_label_set_mnemonic_widget (GTK_LABEL (url_dlg_data->calendar_list_label), + selector); gtk_widget_show (selector); gtk_container_add (GTK_CONTAINER (url_dlg_data->scrolled_window), selector); - gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (url_dlg_data->scrolled_window), - GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC); - gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (url_dlg_data->scrolled_window), - GTK_SHADOW_IN); - + icon_list = e_icon_factory_get_icon_list ("stock_calendar"); if (icon_list) { - gtk_window_set_icon_list (GTK_WINDOW (url_dlg_data->url_dialog), icon_list); + gtk_window_set_icon_list (GTK_WINDOW (url_dlg_data->url_editor), icon_list); g_list_foreach (icon_list, (GFunc) g_object_unref, NULL); g_list_free (icon_list); } diff --git a/calendar/gui/dialogs/url-editor-dialog.glade b/calendar/gui/dialogs/url-editor-dialog.glade index 3685e69bd1..2415a78059 100644 --- a/calendar/gui/dialogs/url-editor-dialog.glade +++ b/calendar/gui/dialogs/url-editor-dialog.glade @@ -5,21 +5,27 @@ <requires lib="gnome"/> <widget class="GtkDialog" id="url_editor"> - <property name="border_width">12</property> <property name="visible">True</property> <property name="title" translatable="yes">Free/Busy Editor</property> <property name="type">GTK_WINDOW_TOPLEVEL</property> - <property name="window_position">GTK_WIN_POS_NONE</property> + <property name="window_position">GTK_WIN_POS_CENTER_ON_PARENT</property> <property name="modal">False</property> + <property name="default_width">380</property> + <property name="default_height">508</property> <property name="resizable">True</property> <property name="destroy_with_parent">False</property> - <property name="has_separator">True</property> + <property name="decorated">True</property> + <property name="skip_taskbar_hint">False</property> + <property name="skip_pager_hint">False</property> + <property name="type_hint">GDK_WINDOW_TYPE_HINT_DIALOG</property> + <property name="gravity">GDK_GRAVITY_NORTH_WEST</property> + <property name="has_separator">False</property> <child internal-child="vbox"> <widget class="GtkVBox" id="dialog-vbox1"> <property name="visible">True</property> <property name="homogeneous">False</property> - <property name="spacing">18</property> + <property name="spacing">0</property> <child internal-child="action_area"> <widget class="GtkHButtonBox" id="dialog-action_area1"> @@ -35,6 +41,7 @@ <property name="label">gtk-cancel</property> <property name="use_stock">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> <property name="response_id">-6</property> </widget> </child> @@ -48,6 +55,7 @@ <property name="label">gtk-ok</property> <property name="use_stock">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> <property name="response_id">-5</property> </widget> </child> @@ -61,73 +69,46 @@ </child> <child> - <widget class="GtkVBox" id="vbox9"> + <widget class="GtkVBox" id="vbox13"> + <property name="border_width">12</property> <property name="visible">True</property> <property name="homogeneous">False</property> - <property name="spacing">6</property> + <property name="spacing">12</property> <child> - <widget class="GtkFrame" id="frame2"> + <widget class="GtkLabel" id="label26"> <property name="visible">True</property> - <property name="label_xalign">0</property> - <property name="label_yalign">0.5</property> - <property name="shadow_type">GTK_SHADOW_ETCHED_IN</property> - - <child> - <widget class="GtkHBox" id="hbox9"> - <property name="border_width">6</property> - <property name="visible">True</property> - <property name="homogeneous">False</property> - <property name="spacing">6</property> - - <child> - <widget class="GtkLabel" id="label18"> - <property name="visible">True</property> - <property name="label" translatable="yes">URL:</property> - <property name="use_underline">False</property> - <property name="use_markup">True</property> - <property name="justify">GTK_JUSTIFY_LEFT</property> - <property name="wrap">False</property> - <property name="selectable">False</property> - <property name="xalign">0.5</property> - <property name="yalign">0.5</property> - <property name="xpad">0</property> - <property name="ypad">0</property> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> - </packing> - </child> + <property name="label" translatable="yes"><b>Publishing _Location</b></property> + <property name="use_underline">True</property> + <property name="use_markup">True</property> + <property name="justify">GTK_JUSTIFY_LEFT</property> + <property name="wrap">False</property> + <property name="selectable">False</property> + <property name="xalign">0</property> + <property name="yalign">0.5</property> + <property name="xpad">0</property> + <property name="ypad">0</property> + <property name="mnemonic_widget">url_entry</property> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> - <child> - <widget class="GtkEntry" id="url_entry"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="editable">True</property> - <property name="visibility">True</property> - <property name="max_length">0</property> - <property name="text" translatable="yes"></property> - <property name="has_frame">True</property> - <property name="invisible_char" translatable="yes">*</property> - <property name="activates_default">False</property> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">True</property> - <property name="fill">True</property> - </packing> - </child> - </widget> - </child> + <child> + <widget class="GtkHBox" id="hbox9"> + <property name="visible">True</property> + <property name="homogeneous">False</property> + <property name="spacing">12</property> <child> - <widget class="GtkLabel" id="label26"> + <widget class="GtkLabel" id="label18"> <property name="visible">True</property> - <property name="label" translatable="yes">Free/Busy Publishing Location</property> + <property name="label" translatable="yes"></property> <property name="use_underline">False</property> - <property name="use_markup">False</property> + <property name="use_markup">True</property> <property name="justify">GTK_JUSTIFY_LEFT</property> <property name="wrap">False</property> <property name="selectable">False</property> @@ -137,38 +118,100 @@ <property name="ypad">0</property> </widget> <packing> - <property name="type">label_item</property> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> + + <child> + <widget class="GtkEntry" id="url_entry"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="editable">True</property> + <property name="visibility">True</property> + <property name="max_length">0</property> + <property name="text" translatable="yes"></property> + <property name="has_frame">True</property> + <property name="invisible_char" translatable="yes">*</property> + <property name="activates_default">False</property> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">True</property> + <property name="fill">True</property> </packing> </child> </widget> <packing> - <property name="padding">6</property> + <property name="padding">0</property> + <property name="expand">True</property> + <property name="fill">True</property> + </packing> + </child> + + <child> + <widget class="GtkLabel" id="label25"> + <property name="visible">True</property> + <property name="label" translatable="yes"><b>Publishing Frequency</b></property> + <property name="use_underline">False</property> + <property name="use_markup">True</property> + <property name="justify">GTK_JUSTIFY_LEFT</property> + <property name="wrap">False</property> + <property name="selectable">False</property> + <property name="xalign">0</property> + <property name="yalign">0.5</property> + <property name="xpad">0</property> + <property name="ypad">0</property> + </widget> + <packing> + <property name="padding">0</property> <property name="expand">False</property> <property name="fill">False</property> </packing> </child> <child> - <widget class="GtkFrame" id="frame1"> + <widget class="GtkHBox" id="hbox10"> <property name="visible">True</property> - <property name="label_xalign">0</property> - <property name="label_yalign">0.5</property> - <property name="shadow_type">GTK_SHADOW_ETCHED_IN</property> + <property name="homogeneous">False</property> + <property name="spacing">12</property> + + <child> + <widget class="GtkLabel" id="label29"> + <property name="visible">True</property> + <property name="label" translatable="yes"></property> + <property name="use_underline">False</property> + <property name="use_markup">False</property> + <property name="justify">GTK_JUSTIFY_LEFT</property> + <property name="wrap">False</property> + <property name="selectable">False</property> + <property name="xalign">0.5</property> + <property name="yalign">0.5</property> + <property name="xpad">0</property> + <property name="ypad">0</property> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> <child> <widget class="GtkVBox" id="vbox12"> - <property name="border_width">6</property> <property name="visible">True</property> <property name="homogeneous">False</property> - <property name="spacing">0</property> + <property name="spacing">6</property> <child> <widget class="GtkRadioButton" id="daily"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">Daily</property> + <property name="label" translatable="yes">_Daily</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> <property name="active">False</property> <property name="inconsistent">False</property> <property name="draw_indicator">True</property> @@ -184,9 +227,10 @@ <widget class="GtkRadioButton" id="weekly"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">Weekly</property> + <property name="label" translatable="yes">_Weekly</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> <property name="active">False</property> <property name="inconsistent">False</property> <property name="draw_indicator">True</property> @@ -203,9 +247,10 @@ <widget class="GtkRadioButton" id="user_publish"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">User Publishes</property> + <property name="label" translatable="yes">_Manual</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> <property name="active">False</property> <property name="inconsistent">False</property> <property name="draw_indicator">True</property> @@ -218,12 +263,51 @@ </packing> </child> </widget> + <packing> + <property name="padding">0</property> + <property name="expand">True</property> + <property name="fill">True</property> + </packing> </child> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">True</property> + <property name="fill">True</property> + </packing> + </child> + + <child> + <widget class="GtkLabel" id="calendar_list_label"> + <property name="visible">True</property> + <property name="label" translatable="yes"><b>Free/Busy C_alendars</b></property> + <property name="use_underline">True</property> + <property name="use_markup">True</property> + <property name="justify">GTK_JUSTIFY_LEFT</property> + <property name="wrap">False</property> + <property name="selectable">False</property> + <property name="xalign">0</property> + <property name="yalign">0.5</property> + <property name="xpad">0</property> + <property name="ypad">0</property> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> + + <child> + <widget class="GtkHBox" id="hbox11"> + <property name="visible">True</property> + <property name="homogeneous">False</property> + <property name="spacing">12</property> <child> - <widget class="GtkLabel" id="label25"> + <widget class="GtkLabel" id="label30"> <property name="visible">True</property> - <property name="label" translatable="yes">Publishing Frequency</property> + <property name="label" translatable="yes"></property> <property name="use_underline">False</property> <property name="use_markup">False</property> <property name="justify">GTK_JUSTIFY_LEFT</property> @@ -235,36 +319,11 @@ <property name="ypad">0</property> </widget> <packing> - <property name="type">label_item</property> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> </packing> </child> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">True</property> - <property name="fill">True</property> - </packing> - </child> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">True</property> - <property name="fill">True</property> - </packing> - </child> - - <child> - <widget class="GtkVBox" id="vbox11"> - <property name="visible">True</property> - <property name="homogeneous">False</property> - <property name="spacing">6</property> - - <child> - <widget class="GtkFrame" id="frame4"> - <property name="visible">True</property> - <property name="label_xalign">0</property> - <property name="label_yalign">0.5</property> - <property name="shadow_type">GTK_SHADOW_ETCHED_IN</property> <child> <widget class="GtkScrolledWindow" id="scrolled_window"> @@ -280,12 +339,51 @@ <placeholder/> </child> </widget> + <packing> + <property name="padding">0</property> + <property name="expand">True</property> + <property name="fill">True</property> + </packing> </child> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">True</property> + <property name="fill">True</property> + </packing> + </child> + + <child> + <widget class="GtkLabel" id="label27"> + <property name="visible">True</property> + <property name="label" translatable="yes"><b>Authentication</b></property> + <property name="use_underline">False</property> + <property name="use_markup">True</property> + <property name="justify">GTK_JUSTIFY_LEFT</property> + <property name="wrap">False</property> + <property name="selectable">False</property> + <property name="xalign">0</property> + <property name="yalign">0.5</property> + <property name="xpad">0</property> + <property name="ypad">0</property> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> + + <child> + <widget class="GtkHBox" id="hbox12"> + <property name="visible">True</property> + <property name="homogeneous">False</property> + <property name="spacing">12</property> <child> - <widget class="GtkLabel" id="label28"> + <widget class="GtkLabel" id="label31"> <property name="visible">True</property> - <property name="label" translatable="yes">Calendars selected for publishing</property> + <property name="label" translatable="yes"></property> <property name="use_underline">False</property> <property name="use_markup">False</property> <property name="justify">GTK_JUSTIFY_LEFT</property> @@ -297,39 +395,26 @@ <property name="ypad">0</property> </widget> <packing> - <property name="type">label_item</property> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> </packing> </child> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> - </packing> - </child> - - <child> - <widget class="GtkFrame" id="frame3"> - <property name="visible">True</property> - <property name="label_xalign">0</property> - <property name="label_yalign">0.5</property> - <property name="shadow_type">GTK_SHADOW_ETCHED_IN</property> <child> <widget class="GtkTable" id="table1"> - <property name="border_width">6</property> <property name="visible">True</property> - <property name="n_rows">2</property> - <property name="n_columns">3</property> + <property name="n_rows">3</property> + <property name="n_columns">2</property> <property name="homogeneous">False</property> <property name="row_spacing">6</property> - <property name="column_spacing">6</property> + <property name="column_spacing">12</property> <child> <widget class="GtkLabel" id="label13"> <property name="visible">True</property> - <property name="label" translatable="yes">Login name:</property> - <property name="use_underline">False</property> + <property name="label" translatable="yes">_Username:</property> + <property name="use_underline">True</property> <property name="use_markup">False</property> <property name="justify">GTK_JUSTIFY_LEFT</property> <property name="wrap">False</property> @@ -338,6 +423,7 @@ <property name="yalign">0.5</property> <property name="xpad">0</property> <property name="ypad">0</property> + <property name="mnemonic_widget">username_entry</property> </widget> <packing> <property name="left_attach">0</property> @@ -352,8 +438,8 @@ <child> <widget class="GtkLabel" id="label14"> <property name="visible">True</property> - <property name="label" translatable="yes">Password:</property> - <property name="use_underline">False</property> + <property name="label" translatable="yes">_Password:</property> + <property name="use_underline">True</property> <property name="use_markup">False</property> <property name="justify">GTK_JUSTIFY_LEFT</property> <property name="wrap">False</property> @@ -362,6 +448,7 @@ <property name="yalign">0.5</property> <property name="xpad">0</property> <property name="ypad">0</property> + <property name="mnemonic_widget">password_entry</property> </widget> <packing> <property name="left_attach">0</property> @@ -419,72 +506,35 @@ <widget class="GtkCheckButton" id="remember_pw"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">Remember password</property> + <property name="label" translatable="yes">_Remember password</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> <property name="active">False</property> <property name="inconsistent">False</property> <property name="draw_indicator">True</property> </widget> <packing> - <property name="left_attach">2</property> - <property name="right_attach">3</property> - <property name="top_attach">1</property> - <property name="bottom_attach">2</property> - <property name="x_options">fill</property> - <property name="y_options"></property> - </packing> - </child> - - <child> - <widget class="GtkLabel" id="label15"> - <property name="visible">True</property> - <property name="label" translatable="yes"></property> - <property name="use_underline">False</property> - <property name="use_markup">False</property> - <property name="justify">GTK_JUSTIFY_LEFT</property> - <property name="wrap">False</property> - <property name="selectable">False</property> - <property name="xalign">0</property> - <property name="yalign">0.5</property> - <property name="xpad">0</property> - <property name="ypad">0</property> - </widget> - <packing> - <property name="left_attach">2</property> - <property name="right_attach">3</property> - <property name="top_attach">0</property> - <property name="bottom_attach">1</property> + <property name="left_attach">0</property> + <property name="right_attach">2</property> + <property name="top_attach">2</property> + <property name="bottom_attach">3</property> <property name="x_options">fill</property> <property name="y_options"></property> </packing> </child> </widget> - </child> - - <child> - <widget class="GtkLabel" id="label27"> - <property name="visible">True</property> - <property name="label" translatable="yes">Authentication Credentials for HTTP Server</property> - <property name="use_underline">False</property> - <property name="use_markup">False</property> - <property name="justify">GTK_JUSTIFY_LEFT</property> - <property name="wrap">False</property> - <property name="selectable">False</property> - <property name="xalign">0.5</property> - <property name="yalign">0.5</property> - <property name="xpad">0</property> - <property name="ypad">0</property> - </widget> <packing> - <property name="type">label_item</property> + <property name="padding">0</property> + <property name="expand">True</property> + <property name="fill">True</property> </packing> </child> </widget> <packing> <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> + <property name="expand">True</property> + <property name="fill">True</property> </packing> </child> </widget> diff --git a/calendar/gui/dialogs/url-editor-dialog.h b/calendar/gui/dialogs/url-editor-dialog.h index a769ef6b80..12930f45cd 100644 --- a/calendar/gui/dialogs/url-editor-dialog.h +++ b/calendar/gui/dialogs/url-editor-dialog.h @@ -48,6 +48,7 @@ struct _UrlDialogData { GtkWidget *weekly; GtkWidget *user_publish; + GtkWidget *calendar_list_label; GtkWidget *scrolled_window; GtkEntry *username_entry; |