aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--ChangeLog7
-rw-r--r--src/ephy-tabs-menu.c5
2 files changed, 10 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index ae36c4b65..d0d42737b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2005-03-14 Christian Persch <chpe@cvs.gnome.org>
+ * src/ephy-tabs-menu.c: (tab_added_cb):
+
+ Use connect_object, to guard against "title" signal emitted
+ when the window is dying. Fixes bug #169833.
+
+2005-03-14 Christian Persch <chpe@cvs.gnome.org>
+
* src/ephy-tabs-menu.c: (tab_removed_cb):
Fix signal handler disconnection; bug #170353.
diff --git a/src/ephy-tabs-menu.c b/src/ephy-tabs-menu.c
index d28bb9a56..c900eab24 100644
--- a/src/ephy-tabs-menu.c
+++ b/src/ephy-tabs-menu.c
@@ -149,8 +149,9 @@ tab_added_cb (EphyNotebook *notebook,
NULL);
sync_tab_title (tab, NULL, action);
- g_signal_connect (tab, "notify::title",
- G_CALLBACK (sync_tab_title), action);
+ /* make sure the action is alive when handling the signal, see bug #169833 */
+ g_signal_connect_object (tab, "notify::title",
+ G_CALLBACK (sync_tab_title), action, 0);
gtk_action_group_add_action_with_accel (priv->action_group, action, NULL);