aboutsummaryrefslogtreecommitdiffstats
path: root/signer/core/api_test.go
blob: 30948f99bfc5daba9c919ec37b8609c40a4a1447 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
// Copyright 2018 The go-ethereum Authors
// This file is part of the go-ethereum library.
//
// The go-ethereum library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// The go-ethereum library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public License
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.

package core_test

import (
    "bytes"
    "context"
    "fmt"
    "io/ioutil"
    "math/big"
    "os"
    "path/filepath"
    "testing"
    "time"

    "github.com/ethereum/go-ethereum/accounts"
    "github.com/ethereum/go-ethereum/accounts/keystore"
    "github.com/ethereum/go-ethereum/common"
    "github.com/ethereum/go-ethereum/common/hexutil"
    "github.com/ethereum/go-ethereum/core/types"
    "github.com/ethereum/go-ethereum/internal/ethapi"
    "github.com/ethereum/go-ethereum/rlp"
    "github.com/ethereum/go-ethereum/signer/core"
    "github.com/ethereum/go-ethereum/signer/fourbyte"
    "github.com/ethereum/go-ethereum/signer/storage"
)

//Used for testing
type headlessUi struct {
    approveCh chan string // to send approve/deny
    inputCh   chan string // to send password
}

func (ui *headlessUi) OnInputRequired(info core.UserInputRequest) (core.UserInputResponse, error) {
    input := <-ui.inputCh
    return core.UserInputResponse{Text: input}, nil
}

func (ui *headlessUi) OnSignerStartup(info core.StartupInfo)        {}
func (ui *headlessUi) RegisterUIServer(api *core.UIServerAPI)       {}
func (ui *headlessUi) OnApprovedTx(tx ethapi.SignTransactionResult) {}

func (ui *headlessUi) ApproveTx(request *core.SignTxRequest) (core.SignTxResponse, error) {

    switch <-ui.approveCh {
    case "Y":
        return core.SignTxResponse{request.Transaction, true}, nil
    case "M": // modify
        // The headless UI always modifies the transaction
        old := big.Int(request.Transaction.Value)
        newVal := big.NewInt(0).Add(&old, big.NewInt(1))
        request.Transaction.Value = hexutil.Big(*newVal)
        return core.SignTxResponse{request.Transaction, true}, nil
    default:
        return core.SignTxResponse{request.Transaction, false}, nil
    }
}

func (ui *headlessUi) ApproveSignData(request *core.SignDataRequest) (core.SignDataResponse, error) {
    approved := "Y" == <-ui.approveCh
    return core.SignDataResponse{approved}, nil
}

func (ui *headlessUi) ApproveListing(request *core.ListRequest) (core.ListResponse, error) {
    approval := <-ui.approveCh
    //fmt.Printf("approval %s\n", approval)
    switch approval {
    case "A":
        return core.ListResponse{request.Accounts}, nil
    case "1":
        l := make([]accounts.Account, 1)
        l[0] = request.Accounts[1]
        return core.ListResponse{l}, nil
    default:
        return core.ListResponse{nil}, nil
    }
}

func (ui *headlessUi) ApproveNewAccount(request *core.NewAccountRequest) (core.NewAccountResponse, error) {
    if "Y" == <-ui.approveCh {
        return core.NewAccountResponse{true}, nil
    }
    return core.NewAccountResponse{false}, nil
}

func (ui *headlessUi) ShowError(message string) {
    //stdout is used by communication
    fmt.Fprintln(os.Stderr, message)
}

func (ui *headlessUi) ShowInfo(message string) {
    //stdout is used by communication
    fmt.Fprintln(os.Stderr, message)
}

func tmpDirName(t *testing.T) string {
    d, err := ioutil.TempDir("", "eth-keystore-test")
    if err != nil {
        t.Fatal(err)
    }
    d, err = filepath.EvalSymlinks(d)
    if err != nil {
        t.Fatal(err)
    }
    return d
}

func setup(t *testing.T) (*core.SignerAPI, *headlessUi) {
    db, err := fourbyte.New()
    if err != nil {
        t.Fatal(err.Error())
    }
    ui := &headlessUi{make(chan string, 20), make(chan string, 20)}
    am := core.StartClefAccountManager(tmpDirName(t), true, true, "")
    api := core.NewSignerAPI(am, 1337, true, ui, db, true, &storage.NoStorage{})
    return api, ui

}
func createAccount(ui *headlessUi, api *core.SignerAPI, t *testing.T) {
    ui.approveCh <- "Y"
    ui.inputCh <- "a_long_password"
    _, err := api.New(context.Background())
    if err != nil {
        t.Fatal(err)
    }
    // Some time to allow changes to propagate
    time.Sleep(250 * time.Millisecond)
}

func failCreateAccountWithPassword(ui *headlessUi, api *core.SignerAPI, password string, t *testing.T) {

    ui.approveCh <- "Y"
    // We will be asked three times to provide a suitable password
    ui.inputCh <- password
    ui.inputCh <- password
    ui.inputCh <- password

    addr, err := api.New(context.Background())
    if err == nil {
        t.Fatal("Should have returned an error")
    }
    if addr != (common.Address{}) {
        t.Fatal("Empty address should be returned")
    }
}

func failCreateAccount(ui *headlessUi, api *core.SignerAPI, t *testing.T) {
    ui.approveCh <- "N"
    addr, err := api.New(context.Background())
    if err != core.ErrRequestDenied {
        t.Fatal(err)
    }
    if addr != (common.Address{}) {
        t.Fatal("Empty address should be returned")
    }
}

func list(ui *headlessUi, api *core.SignerAPI, t *testing.T) ([]common.Address, error) {
    ui.approveCh <- "A"
    return api.List(context.Background())

}

func TestNewAcc(t *testing.T) {
    api, control := setup(t)
    verifyNum := func(num int) {
        list, err := list(control, api, t)
        if err != nil {
            t.Errorf("Unexpected error %v", err)
        }
        if len(list) != num {
            t.Errorf("Expected %d accounts, got %d", num, len(list))
        }
    }
    // Testing create and create-deny
    createAccount(control, api, t)
    createAccount(control, api, t)
    failCreateAccount(control, api, t)
    failCreateAccount(control, api, t)
    createAccount(control, api, t)
    failCreateAccount(control, api, t)
    createAccount(control, api, t)
    failCreateAccount(control, api, t)
    verifyNum(4)

    // Fail to create this, due to bad password
    failCreateAccountWithPassword(control, api, "short", t)
    failCreateAccountWithPassword(control, api, "longerbutbad\rfoo", t)
    verifyNum(4)

    // Testing listing:
    // Listing one Account
    control.approveCh <- "1"
    list, err := api.List(context.Background())
    if err != nil {
        t.Fatal(err)
    }
    if len(list) != 1 {
        t.Fatalf("List should only show one Account")
    }
    // Listing denied
    control.approveCh <- "Nope"
    list, err = api.List(context.Background())
    if len(list) != 0 {
        t.Fatalf("List should be empty")
    }
    if err != core.ErrRequestDenied {
        t.Fatal("Expected deny")
    }
}

func mkTestTx(from common.MixedcaseAddress) core.SendTxArgs {
    to := common.NewMixedcaseAddress(common.HexToAddress("0x1337"))
    gas := hexutil.Uint64(21000)
    gasPrice := (hexutil.Big)(*big.NewInt(2000000000))
    value := (hexutil.Big)(*big.NewInt(1e18))
    nonce := (hexutil.Uint64)(0)
    data := hexutil.Bytes(common.Hex2Bytes("01020304050607080a"))
    tx := core.SendTxArgs{
        From:     from,
        To:       &to,
        Gas:      gas,
        GasPrice: gasPrice,
        Value:    value,
        Data:     &data,
        Nonce:    nonce}
    return tx
}

func TestSignTx(t *testing.T) {
    var (
        list      []common.Address
        res, res2 *ethapi.SignTransactionResult
        err       error
    )

    api, control := setup(t)
    createAccount(control, api, t)
    control.approveCh <- "A"
    list, err = api.List(context.Background())
    if err != nil {
        t.Fatal(err)
    }
    a := common.NewMixedcaseAddress(list[0])

    methodSig := "test(uint)"
    tx := mkTestTx(a)

    control.approveCh <- "Y"
    control.inputCh <- "wrongpassword"
    res, err = api.SignTransaction(context.Background(), tx, &methodSig)
    if res != nil {
        t.Errorf("Expected nil-response, got %v", res)
    }
    if err != keystore.ErrDecrypt {
        t.Errorf("Expected ErrLocked! %v", err)
    }
    control.approveCh <- "No way"
    res, err = api.SignTransaction(context.Background(), tx, &methodSig)
    if res != nil {
        t.Errorf("Expected nil-response, got %v", res)
    }
    if err != core.ErrRequestDenied {
        t.Errorf("Expected ErrRequestDenied! %v", err)
    }
    // Sign with correct password
    control.approveCh <- "Y"
    control.inputCh <- "a_long_password"
    res, err = api.SignTransaction(context.Background(), tx, &methodSig)

    if err != nil {
        t.Fatal(err)
    }
    parsedTx := &types.Transaction{}
    rlp.Decode(bytes.NewReader(res.Raw), parsedTx)

    //The tx should NOT be modified by the UI
    if parsedTx.Value().Cmp(tx.Value.ToInt()) != 0 {
        t.Errorf("Expected value to be unchanged, expected %v got %v", tx.Value, parsedTx.Value())
    }
    control.approveCh <- "Y"
    control.inputCh <- "a_long_password"

    res2, err = api.SignTransaction(context.Background(), tx, &methodSig)
    if err != nil {
        t.Fatal(err)
    }
    if !bytes.Equal(res.Raw, res2.Raw) {
        t.Error("Expected tx to be unmodified by UI")
    }

    //The tx is modified by the UI
    control.approveCh <- "M"
    control.inputCh <- "a_long_password"

    res2, err = api.SignTransaction(context.Background(), tx, &methodSig)
    if err != nil {
        t.Fatal(err)
    }
    parsedTx2 := &types.Transaction{}
    rlp.Decode(bytes.NewReader(res.Raw), parsedTx2)

    //The tx should be modified by the UI
    if parsedTx2.Value().Cmp(tx.Value.ToInt()) != 0 {
        t.Errorf("Expected value to be unchanged, got %v", parsedTx.Value())
    }
    if bytes.Equal(res.Raw, res2.Raw) {
        t.Error("Expected tx to be modified by UI")
    }

}