aboutsummaryrefslogtreecommitdiffstats
path: root/swarm
diff options
context:
space:
mode:
authorMatthew Halpern <matthalp@google.com>2019-02-21 13:37:32 +0800
committerViktor TrĂ³n <viktor.tron@gmail.com>2019-02-21 13:37:32 +0800
commitfbedf62f3ddde6502359741981c2354ef9045f90 (patch)
tree890537944dc2f11dda4984cdfd281ed92a632da5 /swarm
parent9d5e10f5bbeb79b7bae9a4f39386f97907efc601 (diff)
downloadgo-tangerine-fbedf62f3ddde6502359741981c2354ef9045f90.tar
go-tangerine-fbedf62f3ddde6502359741981c2354ef9045f90.tar.gz
go-tangerine-fbedf62f3ddde6502359741981c2354ef9045f90.tar.bz2
go-tangerine-fbedf62f3ddde6502359741981c2354ef9045f90.tar.lz
go-tangerine-fbedf62f3ddde6502359741981c2354ef9045f90.tar.xz
go-tangerine-fbedf62f3ddde6502359741981c2354ef9045f90.tar.zst
go-tangerine-fbedf62f3ddde6502359741981c2354ef9045f90.zip
swarm/storage: fix loop bound for database cleanup (#19085)
The current loop continuation condition is always true as a uint8 is always being checked whether it is less than 255 (its maximum value). Since the loop starts with the value 1, the loop termination can be guarranteed to exit once the value overflows to 0.
Diffstat (limited to 'swarm')
-rw-r--r--swarm/storage/ldbstore.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/swarm/storage/ldbstore.go b/swarm/storage/ldbstore.go
index 9e4d63841..1d5357713 100644
--- a/swarm/storage/ldbstore.go
+++ b/swarm/storage/ldbstore.go
@@ -527,8 +527,8 @@ func (s *LDBStore) Cleanup(f func(*chunk) bool) {
if err != nil {
found := false
- // highest possible proximity is 255
- for po = 1; po <= 255; po++ {
+ // The highest possible proximity is 255, so exit loop upon overflow.
+ for po = uint8(1); po != 0; po++ {
datakey = getDataKey(index.Idx, po)
data, err = s.db.Get(datakey)
if err == nil {