aboutsummaryrefslogtreecommitdiffstats
path: root/.github
diff options
context:
space:
mode:
authorGuillaume Ballet <gballet@gmail.com>2019-04-09 17:53:58 +0800
committerGitHub <noreply@github.com>2019-04-09 17:53:58 +0800
commit1fc3e44ffecee0afde4620805de718320e676130 (patch)
treebb9795b6f89f8eb956042edd025c9ddc989daf60 /.github
parent5fc5971438cd7c22996058c6c86eac7c625449fd (diff)
parent7c28ecbcc3366d73889bd7aedeaeb0c0c544e34b (diff)
downloadgo-tangerine-1fc3e44ffecee0afde4620805de718320e676130.tar
go-tangerine-1fc3e44ffecee0afde4620805de718320e676130.tar.gz
go-tangerine-1fc3e44ffecee0afde4620805de718320e676130.tar.bz2
go-tangerine-1fc3e44ffecee0afde4620805de718320e676130.tar.lz
go-tangerine-1fc3e44ffecee0afde4620805de718320e676130.tar.xz
go-tangerine-1fc3e44ffecee0afde4620805de718320e676130.tar.zst
go-tangerine-1fc3e44ffecee0afde4620805de718320e676130.zip
accounts:smartcard wallet without the dependency on libpcsclite (#19273)
* accounts, core, internal, node: Add support for smartcard wallets * accounts, internal: Changes in response to review * vendor: pull in missing go-echd library * accounts/scwallet, console: user friendly card opening * accounts/scwallet: ordered wallets, tighter events, derivation logs * accounts, console: frendly card errors, support pin unblock * accounts/scwallet: fix crypto API change * accounts/scwallet: rebase and update * Fix some linter issues * Remove the direct dependency on libpcsclite Instead, use a go library that communicates with pcscd over a socket. Also update the changes introduced by @gravityblast since this PR's inception * Temporary fix to the ADBU status call * fix wallet status update This is a temporary fix, better checks need to be performed once the whole process has been validated. * Fix key derivation * Add some documentation * Update a comment to reflect the workings of the updated system * Vendor keycard-go/derivationpath * Formatting fixes * Add instructions on how to install the card * Achieve full transaction signature+sending * PK derivation has to be supported by the card * Fix linter issues * Upgrade to keycard app v2.1.1 * Set gballet as codeowner of the smartcard wallet dir * fix unnecessary condition linter warning * refuse to overwrite the master key of a previously initialized card * refresh the account list when initializing the card * Update the card preparation instructions based on review feedback * 'sanitize' JSON input Co-Authored-By: gballet <gballet@gmail.com> * Apply suggestions from code review Co-Authored-By: gballet <gballet@gmail.com> * fix a serialization error * more review feedback * More review feedback * Can now specify the number of empty accounts to derive * Fix rebase error: include norm package * Update bip-39 ref and remove ebfe/scard from vendor * Add missing dependency
Diffstat (limited to '.github')
-rw-r--r--.github/CODEOWNERS1
1 files changed, 1 insertions, 0 deletions
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 959b50156..ed59c98cc 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -2,6 +2,7 @@
# Each line is a file pattern followed by one or more owners.
accounts/usbwallet @karalabe
+accounts/scwallet @gballet
accounts/abi @gballet
consensus @karalabe
core/ @karalabe @holiman