diff options
author | Felix Lange <fjl@twurst.com> | 2017-01-16 17:20:20 +0800 |
---|---|---|
committer | Felix Lange <fjl@twurst.com> | 2017-01-16 17:32:40 +0800 |
commit | 51f6b6d33f5b50e16f0b04bcccd03ad370f36636 (patch) | |
tree | 871c3a0915a6b75f73619e8626c61fafd701921b /common/hexutil | |
parent | 01f6f2d741e717f669b7ba1d6b88991f28e30c72 (diff) | |
download | dexon-51f6b6d33f5b50e16f0b04bcccd03ad370f36636.tar dexon-51f6b6d33f5b50e16f0b04bcccd03ad370f36636.tar.gz dexon-51f6b6d33f5b50e16f0b04bcccd03ad370f36636.tar.bz2 dexon-51f6b6d33f5b50e16f0b04bcccd03ad370f36636.tar.lz dexon-51f6b6d33f5b50e16f0b04bcccd03ad370f36636.tar.xz dexon-51f6b6d33f5b50e16f0b04bcccd03ad370f36636.tar.zst dexon-51f6b6d33f5b50e16f0b04bcccd03ad370f36636.zip |
common/hexutil: fix EncodeBig, Big.MarshalJSON
The code was too clever and failed to include zeros on a big.Word
boundary.
Diffstat (limited to 'common/hexutil')
-rw-r--r-- | common/hexutil/hexutil.go | 7 | ||||
-rw-r--r-- | common/hexutil/hexutil_test.go | 1 | ||||
-rw-r--r-- | common/hexutil/json.go | 9 |
3 files changed, 4 insertions, 13 deletions
diff --git a/common/hexutil/hexutil.go b/common/hexutil/hexutil.go index 29e6de333..4ec0ee8e6 100644 --- a/common/hexutil/hexutil.go +++ b/common/hexutil/hexutil.go @@ -169,12 +169,7 @@ func EncodeBig(bigint *big.Int) string { if nbits == 0 { return "0x0" } - enc := make([]byte, 2, (nbits/8)*2+2) - copy(enc, "0x") - for i := len(bigint.Bits()) - 1; i >= 0; i-- { - enc = strconv.AppendUint(enc, uint64(bigint.Bits()[i]), 16) - } - return string(enc) + return fmt.Sprintf("0x%x", bigint) } func has0xPrefix(input string) bool { diff --git a/common/hexutil/hexutil_test.go b/common/hexutil/hexutil_test.go index b58b4745c..324e9d348 100644 --- a/common/hexutil/hexutil_test.go +++ b/common/hexutil/hexutil_test.go @@ -46,6 +46,7 @@ var ( {referenceBig("1"), "0x1"}, {referenceBig("ff"), "0xff"}, {referenceBig("112233445566778899aabbccddeeff"), "0x112233445566778899aabbccddeeff"}, + {referenceBig("80a7f2c1bcc396c00"), "0x80a7f2c1bcc396c00"}, } encodeUint64Tests = []marshalTest{ diff --git a/common/hexutil/json.go b/common/hexutil/json.go index c36d862b5..7e4736dd6 100644 --- a/common/hexutil/json.go +++ b/common/hexutil/json.go @@ -109,13 +109,8 @@ func (b *Big) MarshalJSON() ([]byte, error) { if nbits == 0 { return jsonZero, nil } - enc := make([]byte, 3, (nbits/8)*2+4) - copy(enc, `"0x`) - for i := len(bigint.Bits()) - 1; i >= 0; i-- { - enc = strconv.AppendUint(enc, uint64(bigint.Bits()[i]), 16) - } - enc = append(enc, '"') - return enc, nil + enc := fmt.Sprintf(`"0x%x"`, bigint) + return []byte(enc), nil } // UnmarshalJSON implements json.Unmarshaler. |