diff options
| author | Thomas Bocek <tom@tomp2p.net> | 2016-06-03 00:43:27 +0800 |
|---|---|---|
| committer | Thomas Bocek <tom@tomp2p.net> | 2016-06-06 20:27:15 +0800 |
| commit | 89c6c5bb85ff24c152218f245fa366e733c951a7 (patch) | |
| tree | ed0d02d136ed0f2aa06eb617a9feec661005ddfd /accounts/abi/method.go | |
| parent | 16a23ff74056aa306eb8a87272277bc8660f3252 (diff) | |
| download | dexon-89c6c5bb85ff24c152218f245fa366e733c951a7.tar dexon-89c6c5bb85ff24c152218f245fa366e733c951a7.tar.gz dexon-89c6c5bb85ff24c152218f245fa366e733c951a7.tar.bz2 dexon-89c6c5bb85ff24c152218f245fa366e733c951a7.tar.lz dexon-89c6c5bb85ff24c152218f245fa366e733c951a7.tar.xz dexon-89c6c5bb85ff24c152218f245fa366e733c951a7.tar.zst dexon-89c6c5bb85ff24c152218f245fa366e733c951a7.zip | |
accounts/abi: Negative numbers not properly converted in ABI encoding
When converting a negative number e.g., -2, the resulting ABI encoding
should look as follows:
fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe.
However, since the check of the type is for an uint instead of an
int, it results in the following ABI encoding:
0101010101010101010101010101010101010101010101010101010101010102. The
Ethereum ABI
(https://github.com/ethereum/wiki/wiki/Ethereum-Contract-ABI) says,
that signed integers are stored in two's complement which should be
of the form ffffff.... and not 01010101..... for e.g. -1. Thus, I
removed the type check in numbers.go as well as the function S256
as I don't think they are correct. Or maybe I'm missing something?
Diffstat (limited to 'accounts/abi/method.go')
| -rw-r--r-- | accounts/abi/method.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/accounts/abi/method.go b/accounts/abi/method.go index f3d1a44b5..d56f3bc3d 100644 --- a/accounts/abi/method.go +++ b/accounts/abi/method.go @@ -62,7 +62,7 @@ func (m Method) pack(method Method, args ...interface{}) ([]byte, error) { // calculate the offset offset := len(method.Inputs)*32 + len(variableInput) // set the offset - ret = append(ret, packNum(reflect.ValueOf(offset), UintTy)...) + ret = append(ret, packNum(reflect.ValueOf(offset))...) // Append the packed output to the variable input. The variable input // will be appended at the end of the input. variableInput = append(variableInput, packed...) |