diff options
Diffstat (limited to 'libsolidity/inlineasm')
-rw-r--r-- | libsolidity/inlineasm/AsmAnalysis.cpp | 7 | ||||
-rw-r--r-- | libsolidity/inlineasm/AsmAnalysis.h | 5 |
2 files changed, 6 insertions, 6 deletions
diff --git a/libsolidity/inlineasm/AsmAnalysis.cpp b/libsolidity/inlineasm/AsmAnalysis.cpp index e989560d..53f48819 100644 --- a/libsolidity/inlineasm/AsmAnalysis.cpp +++ b/libsolidity/inlineasm/AsmAnalysis.cpp @@ -246,7 +246,7 @@ bool AsmAnalyzer::operator()(assembly::FunctionCall const& _funCall) if (!expectDeposit(1, stackHeight, locationOf(arg))) success = false; } - m_stackHeight += returns - arguments; + m_stackHeight += int(returns) - int(arguments); return success; } @@ -255,9 +255,8 @@ bool AsmAnalyzer::operator()(Block const& _block) bool success = true; m_currentScope = &scope(&_block); - int const virtualVariablesInNextBlock = m_virtualVariablesInNextBlock; + int const initialStackHeight = m_stackHeight - m_virtualVariablesInNextBlock; m_virtualVariablesInNextBlock = 0; - int const initialStackHeight = m_stackHeight; for (auto const& s: _block.statements) if (!boost::apply_visitor(*this, s)) @@ -267,7 +266,7 @@ bool AsmAnalyzer::operator()(Block const& _block) if (identifier.second.type() == typeid(Scope::Variable)) --m_stackHeight; - int const stackDiff = m_stackHeight - initialStackHeight + virtualVariablesInNextBlock; + int const stackDiff = m_stackHeight - initialStackHeight; if (stackDiff != 0) { m_errors.push_back(make_shared<Error>( diff --git a/libsolidity/inlineasm/AsmAnalysis.h b/libsolidity/inlineasm/AsmAnalysis.h index cfc9b25a..ed357561 100644 --- a/libsolidity/inlineasm/AsmAnalysis.h +++ b/libsolidity/inlineasm/AsmAnalysis.h @@ -82,8 +82,9 @@ private: bool expectDeposit(int _deposit, int _oldHeight, SourceLocation const& _location); Scope& scope(assembly::Block const* _block); - /// Number of excess stack slots generated by function arguments to take into account for - /// next block. + /// This is used when we enter the body of a function definition. There, the parameters + /// and return parameters appear as variables which are already on the stack before + /// we enter the block. int m_virtualVariablesInNextBlock = 0; int m_stackHeight = 0; ExternalIdentifierAccess::Resolver const& m_resolver; |