diff options
Diffstat (limited to 'libsolidity/analysis')
-rw-r--r-- | libsolidity/analysis/ReferencesResolver.cpp | 1 | ||||
-rw-r--r-- | libsolidity/analysis/TypeChecker.cpp | 67 | ||||
-rw-r--r-- | libsolidity/analysis/TypeChecker.h | 2 |
3 files changed, 44 insertions, 26 deletions
diff --git a/libsolidity/analysis/ReferencesResolver.cpp b/libsolidity/analysis/ReferencesResolver.cpp index 95643578..0e153045 100644 --- a/libsolidity/analysis/ReferencesResolver.cpp +++ b/libsolidity/analysis/ReferencesResolver.cpp @@ -44,6 +44,7 @@ bool ReferencesResolver::visit(UserDefinedTypeName const& _typeName) fatalDeclarationError(_typeName.location(), "Identifier not found or not unique."); _typeName.annotation().referencedDeclaration = declaration; + _typeName.annotation().contractScope = m_currentContract; return true; } diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp index 0990a9e4..13c2235a 100644 --- a/libsolidity/analysis/TypeChecker.cpp +++ b/libsolidity/analysis/TypeChecker.cpp @@ -1045,34 +1045,43 @@ bool TypeChecker::visit(FunctionCall const& _functionCall) void TypeChecker::endVisit(NewExpression const& _newExpression) { - auto contract = dynamic_cast<ContractDefinition const*>(&dereference(_newExpression.contractName())); - - if (!contract) - fatalTypeError(_newExpression.location(), "Identifier is not a contract."); - if (!contract->annotation().isFullyImplemented) - typeError(_newExpression.location(), "Trying to create an instance of an abstract contract."); - - auto scopeContract = _newExpression.contractName().annotation().contractScope; - scopeContract->annotation().contractDependencies.insert(contract); - solAssert( - !contract->annotation().linearizedBaseContracts.empty(), - "Linearized base contracts not yet available." - ); - if (contractDependenciesAreCyclic(*scopeContract)) - typeError( - _newExpression.location(), - "Circular reference for contract creation (cannot create instance of derived or same contract)." + if (auto contractName = dynamic_cast<UserDefinedTypeName const*>(&_newExpression.typeName())) + { + auto contract = dynamic_cast<ContractDefinition const*>(&dereference(*contractName)); + + if (!contract) + fatalTypeError(_newExpression.location(), "Identifier is not a contract."); + if (!contract->annotation().isFullyImplemented) + typeError(_newExpression.location(), "Trying to create an instance of an abstract contract."); + + auto scopeContract = contractName->annotation().contractScope; + scopeContract->annotation().contractDependencies.insert(contract); + solAssert( + !contract->annotation().linearizedBaseContracts.empty(), + "Linearized base contracts not yet available." ); + if (contractDependenciesAreCyclic(*scopeContract)) + typeError( + _newExpression.location(), + "Circular reference for contract creation (cannot create instance of derived or same contract)." + ); - auto contractType = make_shared<ContractType>(*contract); - TypePointers const& parameterTypes = contractType->constructorType()->parameterTypes(); - _newExpression.annotation().type = make_shared<FunctionType>( - parameterTypes, - TypePointers{contractType}, - strings(), - strings(), - FunctionType::Location::Creation - ); + auto contractType = make_shared<ContractType>(*contract); + TypePointers const& parameterTypes = contractType->constructorType()->parameterTypes(); + _newExpression.annotation().type = make_shared<FunctionType>( + parameterTypes, + TypePointers{contractType}, + strings(), + strings(), + FunctionType::Location::Creation + ); + } + else if (auto arrayTypeName = dynamic_cast<ArrayTypeName const*>(&_newExpression.typeName())) + { + solAssert(false, "Not yet implemented."); + } + else + fatalTypeError(_newExpression.location(), "Contract or array type expected."); } bool TypeChecker::visit(MemberAccess const& _memberAccess) @@ -1288,6 +1297,12 @@ Declaration const& TypeChecker::dereference(Identifier const& _identifier) return *_identifier.annotation().referencedDeclaration; } +Declaration const& TypeChecker::dereference(UserDefinedTypeName const& _typeName) +{ + solAssert(!!_typeName.annotation().referencedDeclaration, "Declaration not stored."); + return *_typeName.annotation().referencedDeclaration; +} + void TypeChecker::expectType(Expression const& _expression, Type const& _expectedType) { _expression.accept(*this); diff --git a/libsolidity/analysis/TypeChecker.h b/libsolidity/analysis/TypeChecker.h index f163f47c..eb396a8c 100644 --- a/libsolidity/analysis/TypeChecker.h +++ b/libsolidity/analysis/TypeChecker.h @@ -108,6 +108,8 @@ private: /// @returns the referenced declaration and throws on error. Declaration const& dereference(Identifier const& _identifier); + /// @returns the referenced declaration and throws on error. + Declaration const& dereference(UserDefinedTypeName const& _typeName); /// Runs type checks on @a _expression to infer its type and then checks that it is implicitly /// convertible to @a _expectedType. |