diff options
author | chriseth <chris@ethereum.org> | 2017-09-12 23:57:55 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-09-12 23:57:55 +0800 |
commit | 5084a9cda9ed913e50cf393d21764a620827191c (patch) | |
tree | 579ff7b68fc24ff60431250ff02388b3c46e34bd /libsolidity | |
parent | 14f103ca6024722cdbfb0a1c2a3837df635fbdef (diff) | |
parent | 10d290cb9b131f620c56c0bc84a9ab5bcf50368b (diff) | |
download | dexon-solidity-5084a9cda9ed913e50cf393d21764a620827191c.tar dexon-solidity-5084a9cda9ed913e50cf393d21764a620827191c.tar.gz dexon-solidity-5084a9cda9ed913e50cf393d21764a620827191c.tar.bz2 dexon-solidity-5084a9cda9ed913e50cf393d21764a620827191c.tar.lz dexon-solidity-5084a9cda9ed913e50cf393d21764a620827191c.tar.xz dexon-solidity-5084a9cda9ed913e50cf393d21764a620827191c.tar.zst dexon-solidity-5084a9cda9ed913e50cf393d21764a620827191c.zip |
Merge pull request #2852 from ssuman/develop
This commit will display warning when there is unused function parameter
Diffstat (limited to 'libsolidity')
-rw-r--r-- | libsolidity/analysis/StaticAnalyzer.cpp | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/libsolidity/analysis/StaticAnalyzer.cpp b/libsolidity/analysis/StaticAnalyzer.cpp index 2f130414..d012c25d 100644 --- a/libsolidity/analysis/StaticAnalyzer.cpp +++ b/libsolidity/analysis/StaticAnalyzer.cpp @@ -69,7 +69,16 @@ void StaticAnalyzer::endVisit(FunctionDefinition const&) m_constructor = false; for (auto const& var: m_localVarUseCount) if (var.second == 0) - m_errorReporter.warning(var.first->location(), "Unused local variable"); + { + if (var.first->isCallableParameter()) + m_errorReporter.warning( + var.first->location(), + "Unused function parameter. Remove or comment out the variable name to silence this warning." + ); + else + m_errorReporter.warning(var.first->location(), "Unused local variable."); + } + m_localVarUseCount.clear(); } |