diff options
| author | chriseth <c@ethdev.com> | 2015-10-07 23:32:05 +0800 |
|---|---|---|
| committer | chriseth <c@ethdev.com> | 2015-10-08 00:13:20 +0800 |
| commit | 35de03626f4b3c9a29f14ad635151aed9642370d (patch) | |
| tree | d8bc99b9e865814b9e41fdaa8306088e5479092c /libsolidity | |
| parent | ab433c9a788bee31417a52d1574a2c8240004901 (diff) | |
| download | dexon-solidity-35de03626f4b3c9a29f14ad635151aed9642370d.tar dexon-solidity-35de03626f4b3c9a29f14ad635151aed9642370d.tar.gz dexon-solidity-35de03626f4b3c9a29f14ad635151aed9642370d.tar.bz2 dexon-solidity-35de03626f4b3c9a29f14ad635151aed9642370d.tar.lz dexon-solidity-35de03626f4b3c9a29f14ad635151aed9642370d.tar.xz dexon-solidity-35de03626f4b3c9a29f14ad635151aed9642370d.tar.zst dexon-solidity-35de03626f4b3c9a29f14ad635151aed9642370d.zip | |
Check invalid integer constants for functions accepting arbitrary arguments.
Diffstat (limited to 'libsolidity')
| -rw-r--r-- | libsolidity/TypeChecker.cpp | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/libsolidity/TypeChecker.cpp b/libsolidity/TypeChecker.cpp index 4b4fc7f1..5bbbd072 100644 --- a/libsolidity/TypeChecker.cpp +++ b/libsolidity/TypeChecker.cpp @@ -824,10 +824,15 @@ bool TypeChecker::visit(FunctionCall const& _functionCall) { // call by positional arguments for (size_t i = 0; i < arguments.size(); ++i) - if ( - !functionType->takesArbitraryParameters() && - !type(*arguments[i])->isImplicitlyConvertibleTo(*parameterTypes[i]) - ) + { + auto const& argType = type(*arguments[i]); + if (functionType->takesArbitraryParameters()) + { + if (auto t = dynamic_cast<IntegerConstantType const*>(argType.get())) + if (!t->integerType()) + typeError(*arguments[i], "Integer constant too large."); + } + else if (!type(*arguments[i])->isImplicitlyConvertibleTo(*parameterTypes[i])) typeError( *arguments[i], "Invalid type for argument in function call. " @@ -837,6 +842,7 @@ bool TypeChecker::visit(FunctionCall const& _functionCall) parameterTypes[i]->toString() + " requested." ); + } } else { |