diff options
| author | Alex Beregszaszi <alex@rtfs.hu> | 2018-08-07 21:25:11 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-07 21:25:11 +0800 |
| commit | a765b5b31cb2c06a0f04204bd6d22a4238625d19 (patch) | |
| tree | 2effa5cd3e9fd88939872883092cbeee7e9cd77b /libsolidity/ast | |
| parent | 4158a310bde90abe83cb61a071d5c7cdc9064593 (diff) | |
| parent | 5298d818c4808377d3acb8980c2e763b9f86ada7 (diff) | |
| download | dexon-solidity-a765b5b31cb2c06a0f04204bd6d22a4238625d19.tar dexon-solidity-a765b5b31cb2c06a0f04204bd6d22a4238625d19.tar.gz dexon-solidity-a765b5b31cb2c06a0f04204bd6d22a4238625d19.tar.bz2 dexon-solidity-a765b5b31cb2c06a0f04204bd6d22a4238625d19.tar.lz dexon-solidity-a765b5b31cb2c06a0f04204bd6d22a4238625d19.tar.xz dexon-solidity-a765b5b31cb2c06a0f04204bd6d22a4238625d19.tar.zst dexon-solidity-a765b5b31cb2c06a0f04204bd6d22a4238625d19.zip | |
Merge pull request #4720 from ethereum/abi-rational-type-identifier
Fix type identifiers for RationalNumberType (on negative numbers)
Diffstat (limited to 'libsolidity/ast')
| -rw-r--r-- | libsolidity/ast/Types.cpp | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/libsolidity/ast/Types.cpp b/libsolidity/ast/Types.cpp index 7bcae812..eff31b8d 100644 --- a/libsolidity/ast/Types.cpp +++ b/libsolidity/ast/Types.cpp @@ -1146,7 +1146,14 @@ TypePointer RationalNumberType::binaryOperatorResult(Token::Value _operator, Typ string RationalNumberType::richIdentifier() const { - return "t_rational_" + m_value.numerator().str() + "_by_" + m_value.denominator().str(); + // rational seemingly will put the sign always on the numerator, + // but let just make it deterministic here. + bigint numerator = abs(m_value.numerator()); + bigint denominator = abs(m_value.denominator()); + if (m_value < 0) + return "t_rational_minus_" + numerator.str() + "_by_" + denominator.str(); + else + return "t_rational_" + numerator.str() + "_by_" + denominator.str(); } bool RationalNumberType::operator==(Type const& _other) const |