diff options
| author | chriseth <chris@ethereum.org> | 2016-08-17 17:28:02 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-08-17 17:28:02 +0800 |
| commit | e7683f4722791d39ca63913ec98feb1ea9f5164d (patch) | |
| tree | a94bb062fc66a955005d7eafa7160ee3ad35dd63 /libsolidity/analysis/SyntaxChecker.h | |
| parent | e4578982c6e1a39ca3457ab1844be37b500dedda (diff) | |
| parent | 15b85e2ea809ab09ec78955e80666b64b80ddbf1 (diff) | |
| download | dexon-solidity-e7683f4722791d39ca63913ec98feb1ea9f5164d.tar dexon-solidity-e7683f4722791d39ca63913ec98feb1ea9f5164d.tar.gz dexon-solidity-e7683f4722791d39ca63913ec98feb1ea9f5164d.tar.bz2 dexon-solidity-e7683f4722791d39ca63913ec98feb1ea9f5164d.tar.lz dexon-solidity-e7683f4722791d39ca63913ec98feb1ea9f5164d.tar.xz dexon-solidity-e7683f4722791d39ca63913ec98feb1ea9f5164d.tar.zst dexon-solidity-e7683f4722791d39ca63913ec98feb1ea9f5164d.zip | |
Merge pull request #836 from chriseth/unusedunderscore
BREAKING: Require modifiers to contain "_".
Diffstat (limited to 'libsolidity/analysis/SyntaxChecker.h')
| -rw-r--r-- | libsolidity/analysis/SyntaxChecker.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/libsolidity/analysis/SyntaxChecker.h b/libsolidity/analysis/SyntaxChecker.h index c836d49f..3198ffd0 100644 --- a/libsolidity/analysis/SyntaxChecker.h +++ b/libsolidity/analysis/SyntaxChecker.h @@ -31,6 +31,7 @@ namespace solidity /** * The module that performs syntax analysis on the AST: * - whether continue/break is in a for/while loop. + * - whether a modifier contains at least one '_' */ class SyntaxChecker: private ASTConstVisitor { @@ -44,6 +45,9 @@ private: /// Adds a new error to the list of errors. void syntaxError(SourceLocation const& _location, std::string const& _description); + virtual bool visit(ModifierDefinition const& _modifier) override; + virtual void endVisit(ModifierDefinition const& _modifier) override; + virtual bool visit(WhileStatement const& _whileStatement) override; virtual void endVisit(WhileStatement const& _whileStatement) override; virtual bool visit(ForStatement const& _forStatement) override; @@ -52,8 +56,13 @@ private: virtual bool visit(Continue const& _continueStatement) override; virtual bool visit(Break const& _breakStatement) override; + virtual bool visit(PlaceholderStatement const& _placeholderStatement) override; + ErrorList& m_errors; + /// Flag that indicates whether a function modifier actually contains '_'. + bool m_placeholderFound = false; + int m_inLoopDepth = 0; }; |