diff options
| author | chriseth <c@ethdev.com> | 2015-04-22 02:09:20 +0800 |
|---|---|---|
| committer | chriseth <c@ethdev.com> | 2015-04-22 17:43:50 +0800 |
| commit | fcb772293bcc07f1723c39fa24da14cb5280e78e (patch) | |
| tree | f940893c65b4f1beadc39e983b060b64f186b4ba | |
| parent | 99a0cb35453ae6b782f18f39b17b1af65018b124 (diff) | |
| download | dexon-solidity-fcb772293bcc07f1723c39fa24da14cb5280e78e.tar dexon-solidity-fcb772293bcc07f1723c39fa24da14cb5280e78e.tar.gz dexon-solidity-fcb772293bcc07f1723c39fa24da14cb5280e78e.tar.bz2 dexon-solidity-fcb772293bcc07f1723c39fa24da14cb5280e78e.tar.lz dexon-solidity-fcb772293bcc07f1723c39fa24da14cb5280e78e.tar.xz dexon-solidity-fcb772293bcc07f1723c39fa24da14cb5280e78e.tar.zst dexon-solidity-fcb772293bcc07f1723c39fa24da14cb5280e78e.zip | |
Fix regarding memory overwrite during sha3 computation.
| -rw-r--r-- | libsolidity/SolidityEndToEndTest.cpp | 20 |
1 files changed, 19 insertions, 1 deletions
diff --git a/libsolidity/SolidityEndToEndTest.cpp b/libsolidity/SolidityEndToEndTest.cpp index d6a240f0..596f710b 100644 --- a/libsolidity/SolidityEndToEndTest.cpp +++ b/libsolidity/SolidityEndToEndTest.cpp @@ -2378,7 +2378,7 @@ BOOST_AUTO_TEST_CASE(event_really_lots_of_data_from_storage) callContractFunction("deposit()"); BOOST_REQUIRE_EQUAL(m_logs.size(), 1); BOOST_CHECK_EQUAL(m_logs[0].address, m_contractAddress); - BOOST_CHECK(m_logs[0].data == encodeArgs(10, 4, 15) + asBytes("ABC")); + BOOST_CHECK(m_logs[0].data == encodeArgs(10, 3, 15) + asBytes("ABC")); BOOST_REQUIRE_EQUAL(m_logs[0].topics.size(), 1); BOOST_CHECK_EQUAL(m_logs[0].topics[0], dev::sha3(string("Deposit(uint256,bytes,uint256)"))); } @@ -2471,6 +2471,24 @@ BOOST_AUTO_TEST_CASE(sha3_multiple_arguments_with_string_literals) bytes{0x66, 0x6f, 0x6f}))); } +BOOST_AUTO_TEST_CASE(sha3_with_bytes) +{ + char const* sourceCode = R"( + contract c { + bytes data; + function foo() returns (bool) + { + data.length = 3; + data[0] = "f"; + data[1] = "o"; + data[2] = "o"; + return sha3(data) == sha3("foo"); + } + })"; + compileAndRun(sourceCode); + BOOST_CHECK(callContractFunction("foo()") == encodeArgs(true)); +} + BOOST_AUTO_TEST_CASE(generic_call) { char const* sourceCode = R"**( |