aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeonardo Alt <leo@ethereum.org>2018-08-03 23:04:56 +0800
committerLeonardo Alt <leo@ethereum.org>2018-11-23 16:43:49 +0800
commitf3c2309c736ffcdb84fc133106b05d1be1eda95a (patch)
treef17d67ec037f7de5235da7df24a73e3406a52e62
parentf44be616c96159fca18ad2f9ca4a1c0cb4218490 (diff)
downloaddexon-solidity-f3c2309c736ffcdb84fc133106b05d1be1eda95a.tar
dexon-solidity-f3c2309c736ffcdb84fc133106b05d1be1eda95a.tar.gz
dexon-solidity-f3c2309c736ffcdb84fc133106b05d1be1eda95a.tar.bz2
dexon-solidity-f3c2309c736ffcdb84fc133106b05d1be1eda95a.tar.lz
dexon-solidity-f3c2309c736ffcdb84fc133106b05d1be1eda95a.tar.xz
dexon-solidity-f3c2309c736ffcdb84fc133106b05d1be1eda95a.tar.zst
dexon-solidity-f3c2309c736ffcdb84fc133106b05d1be1eda95a.zip
Display better error message in SMTLib2
-rw-r--r--libsolidity/formal/SMTLib2Interface.cpp8
-rw-r--r--libsolidity/formal/SMTLib2Interface.h4
-rw-r--r--libsolidity/formal/SMTPortfolio.cpp6
3 files changed, 10 insertions, 8 deletions
diff --git a/libsolidity/formal/SMTLib2Interface.cpp b/libsolidity/formal/SMTLib2Interface.cpp
index 80ecc715..3cfa01b1 100644
--- a/libsolidity/formal/SMTLib2Interface.cpp
+++ b/libsolidity/formal/SMTLib2Interface.cpp
@@ -39,8 +39,8 @@ using namespace dev;
using namespace dev::solidity;
using namespace dev::solidity::smt;
-SMTLib2Interface::SMTLib2Interface(map<h256, string> const& _smtlib2Responses):
- m_smtlib2Responses(_smtlib2Responses)
+SMTLib2Interface::SMTLib2Interface(map<h256, string> const& _queryResponses):
+ m_queryResponses(_queryResponses)
{
reset();
}
@@ -215,8 +215,8 @@ vector<string> SMTLib2Interface::parseValues(string::const_iterator _start, stri
string SMTLib2Interface::querySolver(string const& _input)
{
h256 inputHash = dev::keccak256(_input);
- if (m_smtlib2Responses.count(inputHash))
- return m_smtlib2Responses.at(inputHash);
+ if (m_queryResponses.count(inputHash))
+ return m_queryResponses.at(inputHash);
else
{
m_unhandledQueries.push_back(_input);
diff --git a/libsolidity/formal/SMTLib2Interface.h b/libsolidity/formal/SMTLib2Interface.h
index c67101ae..55fc4096 100644
--- a/libsolidity/formal/SMTLib2Interface.h
+++ b/libsolidity/formal/SMTLib2Interface.h
@@ -44,7 +44,7 @@ namespace smt
class SMTLib2Interface: public SolverInterface, public boost::noncopyable
{
public:
- explicit SMTLib2Interface(std::map<h256, std::string> const& _smtlib2Responses);
+ explicit SMTLib2Interface(std::map<h256, std::string> const& _queryResponses);
void reset() override;
@@ -73,10 +73,10 @@ private:
/// Communicates with the solver via the callback. Throws SMTSolverError on error.
std::string querySolver(std::string const& _input);
- std::map<h256, std::string> const& m_smtlib2Responses;
std::vector<std::string> m_accumulatedOutput;
std::set<std::string> m_variables;
+ std::map<h256, std::string> const& m_queryResponses;
std::vector<std::string> m_unhandledQueries;
};
diff --git a/libsolidity/formal/SMTPortfolio.cpp b/libsolidity/formal/SMTPortfolio.cpp
index 515d6f32..2c95c3fa 100644
--- a/libsolidity/formal/SMTPortfolio.cpp
+++ b/libsolidity/formal/SMTPortfolio.cpp
@@ -45,8 +45,10 @@ SMTPortfolio::SMTPortfolio(map<h256, string> const& _smtlib2Responses)
#else
if (!_smtlib2Responses.empty())
m_errorReporter.warning(
- "Query responses for smtlib2 were given in the auxiliary input, "
- "but this Solidity binary uses an SMT solver directly."
+ "SMT-LIB2 query responses were given in the auxiliary input, "
+ "but this Solidity binary uses an SMT solver (Z3/CVC4) directly."
+ "These responses will be ignored."
+ "Consider disabling Z3/CVC4 at compilation time in order to use SMT-LIB2 responses."
);
#endif
(void)_smtlib2Responses;