diff options
author | chriseth <chris@ethereum.org> | 2018-04-19 23:47:15 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-04-19 23:47:15 +0800 |
commit | 3f7223759a80052085fe527f1f5927fafbe42540 (patch) | |
tree | 1142f3fde31d1bdb794efb81b730fd8cfbf60641 | |
parent | 2546a274ca4ea8cae221945a88f2f069c09180b0 (diff) | |
parent | a79c9a1dfebf08c3ab5bd6a56f72f3e84ba1ecef (diff) | |
download | dexon-solidity-3f7223759a80052085fe527f1f5927fafbe42540.tar dexon-solidity-3f7223759a80052085fe527f1f5927fafbe42540.tar.gz dexon-solidity-3f7223759a80052085fe527f1f5927fafbe42540.tar.bz2 dexon-solidity-3f7223759a80052085fe527f1f5927fafbe42540.tar.lz dexon-solidity-3f7223759a80052085fe527f1f5927fafbe42540.tar.xz dexon-solidity-3f7223759a80052085fe527f1f5927fafbe42540.tar.zst dexon-solidity-3f7223759a80052085fe527f1f5927fafbe42540.zip |
Merge pull request #3949 from ethereum/prepareRelease
Prepare 0.4.23 release.
-rw-r--r-- | Changelog.md | 2 | ||||
-rw-r--r-- | docs/bugs.json | 8 | ||||
-rw-r--r-- | docs/bugs_by_version.json | 8 | ||||
-rwxr-xr-x | scripts/update_bugs_by_version.py | 8 |
4 files changed, 20 insertions, 6 deletions
diff --git a/Changelog.md b/Changelog.md index c5bad5aa..4cfa4385 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,4 +1,4 @@ -### 0.4.23 (unreleased) +### 0.4.23 (2018-04-19) Features: * Build system: Support Ubuntu Bionic. diff --git a/docs/bugs.json b/docs/bugs.json index c642793a..b464be18 100644 --- a/docs/bugs.json +++ b/docs/bugs.json @@ -1,5 +1,13 @@ [ { + "name": "OneOfTwoConstructorsSkipped", + "summary": "If a contract has both a new-style constructor (using the constructor keyword) and an old-style constructor (a function with the same name as the contract) at the same time, one of them will be ignored.", + "description": "If a contract has both a new-style constructor (using the constructor keyword) and an old-style constructor (a function with the same name as the contract) at the same time, one of them will be ignored. There will be a compiler warning about the old-style constructor, so contracts only using new-style constructors are fine.", + "introduced": "0.4.22", + "fixed": "0.4.23", + "severity": "very low" + }, + { "name": "ZeroFunctionSelector", "summary": "It is possible to craft the name of a function such that it is executed instead of the fallback function in very specific circumstances.", "description": "If a function has a selector consisting only of zeros, is payable and part of a contract that does not have a fallback function and at most five external functions in total, this function is called instead of the fallback function if Ether is sent to the contract without data.", diff --git a/docs/bugs_by_version.json b/docs/bugs_by_version.json index 32f305c8..d96bfde3 100644 --- a/docs/bugs_by_version.json +++ b/docs/bugs_by_version.json @@ -423,9 +423,15 @@ "released": "2018-03-07" }, "0.4.22": { - "bugs": [], + "bugs": [ + "OneOfTwoConstructorsSkipped" + ], "released": "2018-04-16" }, + "0.4.23": { + "bugs": [], + "released": "2018-04-19" + }, "0.4.3": { "bugs": [ "ZeroFunctionSelector", diff --git a/scripts/update_bugs_by_version.py b/scripts/update_bugs_by_version.py index c4bc0c9b..cbedf1a5 100755 --- a/scripts/update_bugs_by_version.py +++ b/scripts/update_bugs_by_version.py @@ -35,9 +35,9 @@ for v in versions: continue versions[v]['bugs'] += [bug['name']] -with open(path + '/../docs/bugs_by_version.json', 'r+') as bugs_by_version: +new_contents = json.dumps(versions, sort_keys=True, indent=4) +with open(path + '/../docs/bugs_by_version.json', 'r') as bugs_by_version: old_contents = bugs_by_version.read() - new_contents = json.dumps(versions, sort_keys=True, indent=4) - bugs_by_version.seek(0) +with open(path + '/../docs/bugs_by_version.json', 'w') as bugs_by_version: bugs_by_version.write(new_contents) - sys.exit(old_contents != new_contents)
\ No newline at end of file +sys.exit(old_contents != new_contents) |