aboutsummaryrefslogtreecommitdiffstats
path: root/packages/contracts/src/2.0.0/protocol/Exchange/MixinMatchOrders.sol
Commit message (Collapse)AuthorAgeFilesLines
* Move generated contract wrappers and artifacts into contracts packageAlex Browne2018-10-161-335/+0
|
* safeGetPartialAmount (#1035)Amir Bandeali2018-08-291-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Added Test "Should transfer correct amounts when left order is fully filled and values pass isRoundingErrorCeil but fail isRoundingErrorFloor" * Added RoundingError exception to reference function for getPartialAmount * Added RoundingError exception to reference function for getPartialAmount * Added isRoundingErrorCeil to getPartialAmountCeil reference funtion * Computed new values for "Should give right maker a better buy price when correct price is not integral" that does not have a rounding error * Almost all tests for match orders are passing after adding isRoundingErrorCeil check * WIP commit: Added rounding error checks to getPartialAmount * WIP commit: Added rounding error checks to getPartialAmount * Use safe versions of getPartialAmount * Update Exchange internals tests * Run linter * Found new values for "Should transfer correct amounts when right order fill amount deviates from amount derived by `Exchange.fillOrder`" * Fixed merge conflicts * Run all tests * Cleaned up some comments on match Orders tests * Fix tests for geth
* Merge pull request #986 from 0xProject/feature/contracts/assertionsAmir Bandeali2018-08-251-6/+16
|\ | | | | Add more assertions to assertValidFill
| * Merge branch 'fix/contracts/robustMatching' of github.com:0xProject/0x.js ↵Remco Bloemen2018-08-251-2/+5
| |\ | | | | | | | | | into fix/contracts/robustMatching
| * | Fix mixin apiRemco Bloemen2018-08-251-7/+7
| | |
| * | Split into assertFillable and assertValidFillRemco Bloemen2018-08-251-5/+13
| | |
| * | Update for new assertValidFill signatureRemco Bloemen2018-08-251-1/+3
| | |
* | | Added comments to order matchingGreg Hysen2018-08-251-1/+13
| | |
* | | Rephrased some of the math in MixinMatchOrders to improve readabilityGreg Hysen2018-08-251-3/+3
| | |
* | | Added temporary @todo to MixinMatchOrdersGreg Hysen2018-08-251-4/+4
| | |
* | | Wording in MixinMatchOrdersGreg Hysen2018-08-251-2/+2
| | |
* | | Removed a redundant comment from matchOrdersGreg Hysen2018-08-251-5/+1
| | |
* | | Rounding for fees in match orders addressed, plus exampleGreg Hysen2018-08-251-4/+4
| | |
* | | Added fees to matchOrders (previously in calculateFillResultsGreg Hysen2018-08-251-0/+24
| | |
* | | Removed calculateFillResults from matchOrders workflow. Eliminates ↵Greg Hysen2018-08-251-38/+29
| |/ |/| | | | | compounded rounding errors.
* | Only use one nonReentrant modifier, remove modifier from fillOrderNoThrow ↵Amir Bandeali2018-08-251-1/+1
| | | | | | | | variations
* | Add nonReentrant modifiers on functions that use getCurrentContextAddress ↵Amir Bandeali2018-08-251-1/+1
| | | | | | | | only, add lockMutex modifier on functions that make external calls
* | Add internal fill functions, add reentrancy guard to public functions that ↵Amir Bandeali2018-08-251-0/+3
| | | | | | | | make external calls
* | Append -Floor to getPartialAmount and isRoundingErrorRemco Bloemen2018-08-251-2/+2
|/
* Remove TODOs that won't be addressedAmir Bandeali2018-07-071-3/+0
|
* Apply new linter rulesAmir Bandeali2018-07-071-1/+1
|
* Contracts 2.0.0 were linted with solhintAlex Shafranovich2018-07-061-0/+1
|
* Update file structureAmir Bandeali2018-06-301-0/+301