aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorLeonid <logvinov.leon@gmail.com>2017-10-12 22:51:37 +0800
committerGitHub <noreply@github.com>2017-10-12 22:51:37 +0800
commitf4fbac26945a53b081e616de63cba20e0bff6af7 (patch)
tree0928f4dedbb91a6de5e35ff9dbeaf491c7b9a256 /src
parentc23ea1e688f68f7aeaf24e562d44a0761ab35f7d (diff)
parentb86f6322e16309feea865e1b304dc7da5ce8ec86 (diff)
downloaddexon-sol-tools-f4fbac26945a53b081e616de63cba20e0bff6af7.tar
dexon-sol-tools-f4fbac26945a53b081e616de63cba20e0bff6af7.tar.gz
dexon-sol-tools-f4fbac26945a53b081e616de63cba20e0bff6af7.tar.bz2
dexon-sol-tools-f4fbac26945a53b081e616de63cba20e0bff6af7.tar.lz
dexon-sol-tools-f4fbac26945a53b081e616de63cba20e0bff6af7.tar.xz
dexon-sol-tools-f4fbac26945a53b081e616de63cba20e0bff6af7.tar.zst
dexon-sol-tools-f4fbac26945a53b081e616de63cba20e0bff6af7.zip
Merge pull request #193 from 0xProject/fix/allowance-error
Fix an issue causing fills to throw `INSUFFICIENT_TAKER_ALLOWANCE`
Diffstat (limited to 'src')
-rw-r--r--src/utils/order_validation_utils.ts6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/utils/order_validation_utils.ts b/src/utils/order_validation_utils.ts
index 5d14602db..1d9aac884 100644
--- a/src/utils/order_validation_utils.ts
+++ b/src/utils/order_validation_utils.ts
@@ -102,11 +102,11 @@ export class OrderValidationUtils {
fillTakerTokenAmount: BigNumber.BigNumber, senderAddress: string, zrxTokenAddress: string): Promise<void> {
const fillMakerTokenAmount = this.getFillMakerTokenAmount(signedOrder, fillTakerTokenAmount);
await exchangeTradeEmulator.transferFromAsync(
- signedOrder.makerTokenAddress, signedOrder.maker, signedOrder.taker, fillMakerTokenAmount,
+ signedOrder.makerTokenAddress, signedOrder.maker, senderAddress, fillMakerTokenAmount,
TradeSide.Maker, TransferType.Trade,
);
await exchangeTradeEmulator.transferFromAsync(
- signedOrder.takerTokenAddress, signedOrder.taker, signedOrder.maker, fillTakerTokenAmount,
+ signedOrder.takerTokenAddress, senderAddress, signedOrder.maker, fillTakerTokenAmount,
TradeSide.Taker, TransferType.Trade,
);
await exchangeTradeEmulator.transferFromAsync(
@@ -114,7 +114,7 @@ export class OrderValidationUtils {
TransferType.Fee,
);
await exchangeTradeEmulator.transferFromAsync(
- zrxTokenAddress, signedOrder.taker, signedOrder.feeRecipient, signedOrder.takerFee, TradeSide.Taker,
+ zrxTokenAddress, senderAddress, signedOrder.feeRecipient, signedOrder.takerFee, TradeSide.Taker,
TransferType.Fee,
);
}