aboutsummaryrefslogtreecommitdiffstats
path: root/packages/contract-wrappers
diff options
context:
space:
mode:
authorFabio Berger <me@fabioberger.com>2018-05-17 20:07:44 +0800
committerFabio Berger <me@fabioberger.com>2018-05-17 20:07:44 +0800
commitcf7967e6296aac0a328143e92a22c5682541a576 (patch)
treef413e35218ec48f58d4cb0fbe35bde5643358614 /packages/contract-wrappers
parent0eacbac8f69bf3b5f03029aae338f63462ca3154 (diff)
downloaddexon-sol-tools-cf7967e6296aac0a328143e92a22c5682541a576.tar
dexon-sol-tools-cf7967e6296aac0a328143e92a22c5682541a576.tar.gz
dexon-sol-tools-cf7967e6296aac0a328143e92a22c5682541a576.tar.bz2
dexon-sol-tools-cf7967e6296aac0a328143e92a22c5682541a576.tar.lz
dexon-sol-tools-cf7967e6296aac0a328143e92a22c5682541a576.tar.xz
dexon-sol-tools-cf7967e6296aac0a328143e92a22c5682541a576.tar.zst
dexon-sol-tools-cf7967e6296aac0a328143e92a22c5682541a576.zip
Disable magic number rule in more places where it isn't helping code readability
Diffstat (limited to 'packages/contract-wrappers')
-rw-r--r--packages/contract-wrappers/test/order_validation_test.ts20
1 files changed, 10 insertions, 10 deletions
diff --git a/packages/contract-wrappers/test/order_validation_test.ts b/packages/contract-wrappers/test/order_validation_test.ts
index ed2159026..d9077d6e4 100644
--- a/packages/contract-wrappers/test/order_validation_test.ts
+++ b/packages/contract-wrappers/test/order_validation_test.ts
@@ -207,8 +207,8 @@ describe('OrderValidation', () => {
takerAddress,
fillableAmount,
);
- const sixthIndex = 6;
- const nonTakerAddress = userAddresses[sixthIndex];
+ // tslint:disable-next-line:custom-no-magic-numbers
+ const nonTakerAddress = userAddresses[6];
return expect(
contractWrappers.exchange.validateFillOrderThrowIfInvalidAsync(
signedOrder,
@@ -355,8 +355,8 @@ describe('OrderValidation', () => {
takerAddress,
zrxTokenAddress,
);
- const expectedCallCount = 4;
- expect(transferFromAsync.callCount).to.be.equal(expectedCallCount);
+ // tslint:disable-next-line:custom-no-magic-numbers
+ expect(transferFromAsync.callCount).to.be.equal(4);
expect(
transferFromAsync
.getCall(0)
@@ -426,8 +426,8 @@ describe('OrderValidation', () => {
takerAddress,
zrxTokenAddress,
);
- const expectedCallCount = 4;
- expect(transferFromAsync.callCount).to.be.equal(expectedCallCount);
+ // tslint:disable-next-line:custom-no-magic-numbers
+ expect(transferFromAsync.callCount).to.be.equal(4);
expect(
transferFromAsync
.getCall(0)
@@ -495,8 +495,8 @@ describe('OrderValidation', () => {
takerAddress,
zrxTokenAddress,
);
- const expectedCallCount = 4;
- expect(transferFromAsync.callCount).to.be.equal(expectedCallCount);
+ // tslint:disable-next-line:custom-no-magic-numbers
+ expect(transferFromAsync.callCount).to.be.equal(4);
const makerFillAmount = transferFromAsync.getCall(0).args[3];
expect(makerFillAmount).to.be.bignumber.equal(makerTokenAmount);
});
@@ -523,8 +523,8 @@ describe('OrderValidation', () => {
);
const makerPartialFee = makerFee.div(2);
const takerPartialFee = takerFee.div(2);
- const expectedCallCount = 4;
- expect(transferFromAsync.callCount).to.be.equal(expectedCallCount);
+ // tslint:disable-next-line:custom-no-magic-numbers
+ expect(transferFromAsync.callCount).to.be.equal(4);
const partialMakerFee = transferFromAsync.getCall(2).args[3];
expect(partialMakerFee).to.be.bignumber.equal(makerPartialFee);
const partialTakerFee = transferFromAsync.getCall(3).args[3];