aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Hysen <greg.hysen@gmail.com>2018-12-05 06:03:48 +0800
committerGreg Hysen <greg.hysen@gmail.com>2018-12-19 05:36:05 +0800
commitba986432eca33ffb4d3c916a78049c6633147b82 (patch)
tree09c1c2724be8335c900a27bac6526755a5b795e2
parent3bb147b0f1554366733098dac1af924225effc26 (diff)
downloaddexon-sol-tools-ba986432eca33ffb4d3c916a78049c6633147b82.tar
dexon-sol-tools-ba986432eca33ffb4d3c916a78049c6633147b82.tar.gz
dexon-sol-tools-ba986432eca33ffb4d3c916a78049c6633147b82.tar.bz2
dexon-sol-tools-ba986432eca33ffb4d3c916a78049c6633147b82.tar.lz
dexon-sol-tools-ba986432eca33ffb4d3c916a78049c6633147b82.tar.xz
dexon-sol-tools-ba986432eca33ffb4d3c916a78049c6633147b82.tar.zst
dexon-sol-tools-ba986432eca33ffb4d3c916a78049c6633147b82.zip
Some comments
-rw-r--r--packages/contracts/contracts/extensions/CompliantForwarder/CompliantForwarder.sol8
1 files changed, 4 insertions, 4 deletions
diff --git a/packages/contracts/contracts/extensions/CompliantForwarder/CompliantForwarder.sol b/packages/contracts/contracts/extensions/CompliantForwarder/CompliantForwarder.sol
index 2dce95716..71c124292 100644
--- a/packages/contracts/contracts/extensions/CompliantForwarder/CompliantForwarder.sol
+++ b/packages/contracts/contracts/extensions/CompliantForwarder/CompliantForwarder.sol
@@ -229,6 +229,7 @@ contract CompliantForwarder is ExchangeSelectors{
case 0x4ac1478200000000000000000000000000000000000000000000000000000000 {} // batchCancelOrders
case 0x4f9559b100000000000000000000000000000000000000000000000000000000 {} // cancelOrdersUpTo
default {
+ // @TODO Revert with `Error("INVALID_OR_UNHANDLED_EXCHANGE_SELECTOR")`
revert(0, 100)
}
@@ -272,9 +273,9 @@ contract CompliantForwarder is ExchangeSelectors{
if eq(addressBalance, 0) {
// Revert with `Error("AT_LEAST_ONE_ADDRESS_HAS_ZERO_BALANCE")`
mstore(0, 0x08c379a000000000000000000000000000000000000000000000000000000000)
- mstore(32, 0x0000002000000000000000000000000000000000000000000000000000000000)
- mstore(64, 0x0000002541545f4c454153545f4f4e455f414444524553535f4841535f5a4552)
- mstore(96, 0x4f5f42414c414e43450000000000000000000000000000000000000000000000)
+ mstore(0x20, 0x0000002000000000000000000000000000000000000000000000000000000000)
+ mstore(0x40, 0x0000002541545f4c454153545f4f4e455f414444524553535f4841535f5a4552)
+ mstore(0x60, 0x4f5f42414c414e43450000000000000000000000000000000000000000000000)
revert(0, 109)
}
}
@@ -283,7 +284,6 @@ contract CompliantForwarder is ExchangeSelectors{
validatedAddresses := addressesToValidate
}
-
///// If we hit this point then all addresses are valid /////
emit ValidatedAddresses(validatedAddresses);