aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOlaf Tomalka <olaf@tomalka.me>2018-01-15 23:02:42 +0800
committerOlaf Tomalka <olaf@tomalka.me>2018-01-15 23:02:42 +0800
commita53e6db537289e088f107acfc5d7202892c92983 (patch)
tree867d57b925dbfc59d842cc4a44ab8069148e472e
parent62e3feeb94bcbd8dd32cba24a0270b4afabce7e8 (diff)
downloaddexon-sol-tools-a53e6db537289e088f107acfc5d7202892c92983.tar
dexon-sol-tools-a53e6db537289e088f107acfc5d7202892c92983.tar.gz
dexon-sol-tools-a53e6db537289e088f107acfc5d7202892c92983.tar.bz2
dexon-sol-tools-a53e6db537289e088f107acfc5d7202892c92983.tar.lz
dexon-sol-tools-a53e6db537289e088f107acfc5d7202892c92983.tar.xz
dexon-sol-tools-a53e6db537289e088f107acfc5d7202892c92983.tar.zst
dexon-sol-tools-a53e6db537289e088f107acfc5d7202892c92983.zip
Fix web3 typing defaultAccount not allowing `undefined`
The default value for the defaultAccount property is undefined, this happens in real-life scenarios, and so the type should explicitly warn users about it
-rw-r--r--packages/web3-typescript-typings/CHANGELOG.md1
-rw-r--r--packages/web3-typescript-typings/index.d.ts2
2 files changed, 2 insertions, 1 deletions
diff --git a/packages/web3-typescript-typings/CHANGELOG.md b/packages/web3-typescript-typings/CHANGELOG.md
index e77b6e113..5544c95c3 100644
--- a/packages/web3-typescript-typings/CHANGELOG.md
+++ b/packages/web3-typescript-typings/CHANGELOG.md
@@ -3,3 +3,4 @@
## v0.9.3 - _January 11, 2018_
* Add type for getData on a contract
+* Fixed the `defaultAccount` not allowing for `undefined` value
diff --git a/packages/web3-typescript-typings/index.d.ts b/packages/web3-typescript-typings/index.d.ts
index b4fc146b3..ff379cb3d 100644
--- a/packages/web3-typescript-typings/index.d.ts
+++ b/packages/web3-typescript-typings/index.d.ts
@@ -170,7 +170,7 @@ declare module 'web3' {
gasPrice: BigNumber.BigNumber;
accounts: string[];
blockNumber: number;
- defaultAccount: string;
+ defaultAccount?: string;
defaultBlock: Web3.BlockParam;
syncing: Web3.SyncingResult;
compile: {