aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabio Berger <me@fabioberger.com>2018-03-21 05:41:21 +0800
committerFabio Berger <me@fabioberger.com>2018-03-21 05:41:21 +0800
commit647bc5a63ecccdcaaad5390d5c7dd5a8d3d07996 (patch)
treeef3bb8433ad32e1bf7710170b25e4e6c06a00203
parent4f76bb2a12e7741be4fbed0455e53de798efa12e (diff)
downloaddexon-sol-tools-647bc5a63ecccdcaaad5390d5c7dd5a8d3d07996.tar
dexon-sol-tools-647bc5a63ecccdcaaad5390d5c7dd5a8d3d07996.tar.gz
dexon-sol-tools-647bc5a63ecccdcaaad5390d5c7dd5a8d3d07996.tar.bz2
dexon-sol-tools-647bc5a63ecccdcaaad5390d5c7dd5a8d3d07996.tar.lz
dexon-sol-tools-647bc5a63ecccdcaaad5390d5c7dd5a8d3d07996.tar.xz
dexon-sol-tools-647bc5a63ecccdcaaad5390d5c7dd5a8d3d07996.tar.zst
dexon-sol-tools-647bc5a63ecccdcaaad5390d5c7dd5a8d3d07996.zip
Rename method for clarity
-rw-r--r--packages/0x.js/src/0x.ts2
-rw-r--r--packages/web3-wrapper/src/index.ts2
2 files changed, 2 insertions, 2 deletions
diff --git a/packages/0x.js/src/0x.ts b/packages/0x.js/src/0x.ts
index 09da4b046..3f323546c 100644
--- a/packages/0x.js/src/0x.ts
+++ b/packages/0x.js/src/0x.ts
@@ -260,7 +260,7 @@ export class ZeroEx {
msgHashHex = ethUtil.bufferToHex(msgHashBuff);
}
- const signature = await this._web3Wrapper.signTransactionAsync(normalizedSignerAddress, msgHashHex);
+ const signature = await this._web3Wrapper.signMessageAsync(normalizedSignerAddress, msgHashHex);
// HACK: There is no consensus on whether the signatureHex string should be formatted as
// v + r + s OR r + s + v, and different clients (even different versions of the same client)
diff --git a/packages/web3-wrapper/src/index.ts b/packages/web3-wrapper/src/index.ts
index e508c4f5b..975649a75 100644
--- a/packages/web3-wrapper/src/index.ts
+++ b/packages/web3-wrapper/src/index.ts
@@ -70,7 +70,7 @@ export class Web3Wrapper {
const codeIsEmpty = /^0x0{0,40}$/i.test(code);
return !codeIsEmpty;
}
- public async signTransactionAsync(address: string, message: string): Promise<string> {
+ public async signMessageAsync(address: string, message: string): Promise<string> {
const signData = await promisify<string>(this._web3.eth.sign)(address, message);
return signData;
}