diff options
author | Leonid Logvinov <logvinov.leon@gmail.com> | 2017-06-08 18:20:01 +0800 |
---|---|---|
committer | Leonid Logvinov <logvinov.leon@gmail.com> | 2017-06-08 18:20:01 +0800 |
commit | cb68f9c9ec52463a1c9a865a446bc9acbc4b703d (patch) | |
tree | c769c066a3716497bde0ec440c84efd36394f4e6 /test/exchange_wrapper_test.ts | |
parent | a328f0c8053173fd8e1f75b808228c3edb617bcc (diff) | |
download | dexon-0x-contracts-cb68f9c9ec52463a1c9a865a446bc9acbc4b703d.tar dexon-0x-contracts-cb68f9c9ec52463a1c9a865a446bc9acbc4b703d.tar.gz dexon-0x-contracts-cb68f9c9ec52463a1c9a865a446bc9acbc4b703d.tar.bz2 dexon-0x-contracts-cb68f9c9ec52463a1c9a865a446bc9acbc4b703d.tar.lz dexon-0x-contracts-cb68f9c9ec52463a1c9a865a446bc9acbc4b703d.tar.xz dexon-0x-contracts-cb68f9c9ec52463a1c9a865a446bc9acbc4b703d.tar.zst dexon-0x-contracts-cb68f9c9ec52463a1c9a865a446bc9acbc4b703d.zip |
Remove tests for isValidSignatureUsingContractCallAsync
Diffstat (limited to 'test/exchange_wrapper_test.ts')
-rw-r--r-- | test/exchange_wrapper_test.ts | 78 |
1 files changed, 0 insertions, 78 deletions
diff --git a/test/exchange_wrapper_test.ts b/test/exchange_wrapper_test.ts index aed3c3c0b..bd52f155a 100644 --- a/test/exchange_wrapper_test.ts +++ b/test/exchange_wrapper_test.ts @@ -51,84 +51,6 @@ describe('ExchangeWrapper', () => { afterEach(async () => { await blockchainLifecycle.revertAsync(); }); - describe('#isValidSignatureUsingContractCallAsync', () => { - // The Exchange smart contract `isValidSignature` method only validates orderHashes and assumes - // the length of the data is exactly 32 bytes. Thus for these tests, we use data of this size. - const dataHex = '0x6927e990021d23b1eb7b8789f6a6feaf98fe104bb0cf8259421b79f9a34222b0'; - const signature = { - v: 27, - r: '0x61a3ed31b43c8780e905a260a35faefcc527be7516aa11c0256729b5b351bc33', - s: '0x40349190569279751135161d22529dc25add4f6069af05be04cacbda2ace2254', - }; - const address = '0x5409ed021d9299bf6814279a6a1411a7e866a631'; - describe('should throw if passed a malformed signature', () => { - it('malformed v', async () => { - const malformedSignature = { - v: 34, - r: signature.r, - s: signature.s, - }; - return expect((zeroEx.exchange as any) - .isValidSignatureUsingContractCallAsync(dataHex, malformedSignature, address), - ).to.be.rejected(); - }); - it('r lacks 0x prefix', async () => { - const malformedR = signature.r.replace('0x', ''); - const malformedSignature = { - v: signature.v, - r: malformedR, - s: signature.s, - }; - return expect((zeroEx.exchange as any) - .isValidSignatureUsingContractCallAsync(dataHex, malformedSignature, address), - ).to.be.rejected(); - }); - it('r is too short', async () => { - const malformedR = signature.r.substr(10); - const malformedSignature = { - v: signature.v, - r: malformedR, - s: signature.s.replace('0', 'z'), - }; - return expect((zeroEx.exchange as any) - .isValidSignatureUsingContractCallAsync(dataHex, malformedSignature, address), - ).to.be.rejected(); - }); - it('s is not hex', async () => { - const malformedS = signature.s.replace('0', 'z'); - const malformedSignature = { - v: signature.v, - r: signature.r, - s: malformedS, - }; - return expect((zeroEx.exchange as any) - .isValidSignatureUsingContractCallAsync(dataHex, malformedSignature, address), - ).to.be.rejected(); - }); - }); - it('should return false if the data doesn\'t pertain to the signature & address', async () => { - const isValid = await (zeroEx.exchange as any) - .isValidSignatureUsingContractCallAsync('0x0', signature, address); - expect(isValid).to.be.false(); - }); - it('should return false if the address doesn\'t pertain to the signature & dataHex', async () => { - const validUnrelatedAddress = '0x8b0292B11a196601eD2ce54B665CaFEca0347D42'; - const isValid = await (zeroEx.exchange as any) - .isValidSignatureUsingContractCallAsync(dataHex, signature, validUnrelatedAddress); - expect(isValid).to.be.false(); - }); - it('should return false if the signature doesn\'t pertain to the dataHex & address', async () => { - const wrongSignature = {...signature, v: 28}; - const isValid = await (zeroEx.exchange as any) - .isValidSignatureUsingContractCallAsync(dataHex, wrongSignature, address); - expect(isValid).to.be.false(); - }); - it('should return true if the signature does pertain to the dataHex & address', async () => { - const isValid = await (zeroEx.exchange as any) - .isValidSignatureUsingContractCallAsync(dataHex, signature, address); - expect(isValid).to.be.true(); - }); - }); describe('#fillOrKillOrderAsync', () => { let makerTokenAddress: string; let takerTokenAddress: string; |