diff options
author | Fabio Berger <me@fabioberger.com> | 2017-06-02 18:15:50 +0800 |
---|---|---|
committer | Fabio Berger <me@fabioberger.com> | 2017-06-02 18:15:50 +0800 |
commit | fc7592d73f1613b11e4b48904bfb041cccca5800 (patch) | |
tree | aef03ea37e7bed7209bccca3c1965ac99d09c954 /src | |
parent | 5155f4980440f1c91006b124406c8b4a7a90e300 (diff) | |
download | dexon-0x-contracts-fc7592d73f1613b11e4b48904bfb041cccca5800.tar dexon-0x-contracts-fc7592d73f1613b11e4b48904bfb041cccca5800.tar.gz dexon-0x-contracts-fc7592d73f1613b11e4b48904bfb041cccca5800.tar.bz2 dexon-0x-contracts-fc7592d73f1613b11e4b48904bfb041cccca5800.tar.lz dexon-0x-contracts-fc7592d73f1613b11e4b48904bfb041cccca5800.tar.xz dexon-0x-contracts-fc7592d73f1613b11e4b48904bfb041cccca5800.tar.zst dexon-0x-contracts-fc7592d73f1613b11e4b48904bfb041cccca5800.zip |
Fix getTransactionSenderAccountIfExistsAsync to return true senderAddress or undefined if non available
Diffstat (limited to 'src')
-rw-r--r-- | src/0x.js.ts | 7 | ||||
-rw-r--r-- | src/web3_wrapper.ts | 2 |
2 files changed, 5 insertions, 4 deletions
diff --git a/src/0x.js.ts b/src/0x.js.ts index 6713ec885..679d748e7 100644 --- a/src/0x.js.ts +++ b/src/0x.js.ts @@ -124,10 +124,11 @@ export class ZeroEx { this.web3Wrapper.setDefaultAccount(account); } /** - * Gets default account for sending transactions. + * Get the default account set for sending transactions. */ - public getTransactionSenderAccount(): string { - return this.web3Wrapper.getDefaultAccount(); + public async getTransactionSenderAccountIfExistsAsync(): Promise<string|undefined> { + const senderAccountIfExists = await this.web3Wrapper.getSenderAddressIfExistsAsync(); + return senderAccountIfExists; } /** * Computes the orderHash given the order parameters and returns it as a hex encoded string. diff --git a/src/web3_wrapper.ts b/src/web3_wrapper.ts index 900c127d5..49bd8b67d 100644 --- a/src/web3_wrapper.ts +++ b/src/web3_wrapper.ts @@ -69,7 +69,7 @@ export class Web3Wrapper { const {timestamp} = await promisify(this.web3.eth.getBlock)(blockHash); return timestamp; } - private async getSenderAddressIfExistsAsync(): Promise<string|undefined> { + public async getSenderAddressIfExistsAsync(): Promise<string|undefined> { const defaultAccount = this.web3.eth.defaultAccount; if (!_.isUndefined(defaultAccount)) { return defaultAccount; |