aboutsummaryrefslogtreecommitdiffstats
path: root/packages
diff options
context:
space:
mode:
authorFabio Berger <me@fabioberger.com>2018-08-23 22:08:02 +0800
committerFabio Berger <me@fabioberger.com>2018-08-23 22:08:02 +0800
commit610caef73faf735a9b9f38863acee007280151be (patch)
treecf46c57e861038dc495841304027a0e809f477c0 /packages
parent29a9e1fc4ec6bc902dc8e76a4af712f2dff4ffb6 (diff)
downloaddexon-0x-contracts-610caef73faf735a9b9f38863acee007280151be.tar
dexon-0x-contracts-610caef73faf735a9b9f38863acee007280151be.tar.gz
dexon-0x-contracts-610caef73faf735a9b9f38863acee007280151be.tar.bz2
dexon-0x-contracts-610caef73faf735a9b9f38863acee007280151be.tar.lz
dexon-0x-contracts-610caef73faf735a9b9f38863acee007280151be.tar.xz
dexon-0x-contracts-610caef73faf735a9b9f38863acee007280151be.tar.zst
dexon-0x-contracts-610caef73faf735a9b9f38863acee007280151be.zip
Fix comments
Diffstat (limited to 'packages')
-rw-r--r--packages/monorepo-scripts/src/utils/github_release_utils.ts11
-rw-r--r--packages/react-docs/src/utils/typedoc_utils.ts1
2 files changed, 3 insertions, 9 deletions
diff --git a/packages/monorepo-scripts/src/utils/github_release_utils.ts b/packages/monorepo-scripts/src/utils/github_release_utils.ts
index 9b5b26d7e..0f3485de0 100644
--- a/packages/monorepo-scripts/src/utils/github_release_utils.ts
+++ b/packages/monorepo-scripts/src/utils/github_release_utils.ts
@@ -65,6 +65,9 @@ export async function publishReleaseNotesAsync(updatedPublishPackages: Package[]
prerelease: false,
reuseRelease: true,
reuseDraftOnly: false,
+ // TODO: Currently publish-release doesn't let you specify the labels for each asset uploaded
+ // Ideally we would like to name the assets after the package they are from
+ // Source: https://github.com/remixz/publish-release/issues/39
assets: finalAssets,
};
@@ -75,9 +78,6 @@ export async function publishReleaseNotesAsync(updatedPublishPackages: Package[]
}
utils.log('Publishing release notes ', releaseName, '...');
- // TODO: Currently publish-release doesn't let you specify the labels for each asset uploaded
- // Ideally we would like to name the assets after the package they are from
- // Source: https://github.com/remixz/publish-release/issues/39
await publishReleaseAsync(publishReleaseConfigs);
}
@@ -107,11 +107,6 @@ function getReleaseNotesForPackage(packageName: string, version: string): string
if (latestLog.changes.length === 1 && latestLog.changes[0].note === constants.dependenciesUpdatedMessage) {
return '';
}
- // We sanity check that the version for the changelog notes we are about to publish to Github
- // correspond to the new version of the package.
- // if (version !== latestLog.version) {
- // throw new Error('Expected CHANGELOG.json latest entry version to coincide with published version.');
- // }
let notes = '';
_.each(latestLog.changes, change => {
notes += `* ${change.note}`;
diff --git a/packages/react-docs/src/utils/typedoc_utils.ts b/packages/react-docs/src/utils/typedoc_utils.ts
index 76443ad81..b867b51b4 100644
--- a/packages/react-docs/src/utils/typedoc_utils.ts
+++ b/packages/react-docs/src/utils/typedoc_utils.ts
@@ -40,7 +40,6 @@ export class TypeDocUtils {
this._externalExportToLink = generatedDocJson.metadata.externalExportToLink;
this._typeDocJson = generatedDocJson.typedocJson;
- // TODO: Extract the non typeDoc exports, and render them somehow
this._typeDocNameOrder = _.compact(
_.flatten(
_.map(exportPathOrder, exportPath => {