diff options
author | fragosti <francesco.agosti93@gmail.com> | 2018-10-25 03:52:32 +0800 |
---|---|---|
committer | fragosti <francesco.agosti93@gmail.com> | 2018-10-25 03:52:32 +0800 |
commit | f89b314a94f867fa905a1ce18eba9336ee4d1634 (patch) | |
tree | 0af014893300c068c86b0189d237aadff376171d /packages/instant/src/components/scaling_input.tsx | |
parent | 47737d4d0fce56454c9ee2b43782b824b88cb942 (diff) | |
download | dexon-0x-contracts-f89b314a94f867fa905a1ce18eba9336ee4d1634.tar dexon-0x-contracts-f89b314a94f867fa905a1ce18eba9336ee4d1634.tar.gz dexon-0x-contracts-f89b314a94f867fa905a1ce18eba9336ee4d1634.tar.bz2 dexon-0x-contracts-f89b314a94f867fa905a1ce18eba9336ee4d1634.tar.lz dexon-0x-contracts-f89b314a94f867fa905a1ce18eba9336ee4d1634.tar.xz dexon-0x-contracts-f89b314a94f867fa905a1ce18eba9336ee4d1634.tar.zst dexon-0x-contracts-f89b314a94f867fa905a1ce18eba9336ee4d1634.zip |
fix: address PR feedback
Diffstat (limited to 'packages/instant/src/components/scaling_input.tsx')
-rw-r--r-- | packages/instant/src/components/scaling_input.tsx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/packages/instant/src/components/scaling_input.tsx b/packages/instant/src/components/scaling_input.tsx index fadb3466b..6948c86c1 100644 --- a/packages/instant/src/components/scaling_input.tsx +++ b/packages/instant/src/components/scaling_input.tsx @@ -53,7 +53,7 @@ export class ScalingInput extends React.Component<ScalingInputProps, ScalingInpu public state = { inputWidthPxAtPhaseChange: undefined, }; - private readonly _inputRef = React.createRef(); + private readonly _inputRef = React.createRef<HTMLInputElement>(); public static getPhase(textLengthThreshold: number, value: string): ScalingInputPhase { if (value.length <= textLengthThreshold) { return ScalingInputPhase.FixedFontSize; @@ -101,8 +101,6 @@ export class ScalingInput extends React.Component<ScalingInputProps, ScalingInpu ): void { const prevPhase = ScalingInput.getPhaseFromProps(prevProps); const curPhase = ScalingInput.getPhaseFromProps(this.props); - const prevFontSize = ScalingInput.calculateFontSizeFromProps(prevProps, prevPhase); - const curFontSize = ScalingInput.calculateFontSizeFromProps(this.props, curPhase); // if we went from anything else to end, fix to the current width as it shouldn't change as we grow if (prevPhase !== ScalingInputPhase.ScalingFontSize && curPhase === ScalingInputPhase.ScalingFontSize) { this.setState({ @@ -115,6 +113,8 @@ export class ScalingInput extends React.Component<ScalingInputProps, ScalingInpu inputWidthPxAtPhaseChange: undefined, }); } + const prevFontSize = ScalingInput.calculateFontSizeFromProps(prevProps, prevPhase); + const curFontSize = ScalingInput.calculateFontSizeFromProps(this.props, curPhase); // If font size has changed, notify. if (prevFontSize !== curFontSize) { this.props.onFontSizeChange(curFontSize); @@ -166,6 +166,6 @@ export class ScalingInput extends React.Component<ScalingInputProps, ScalingInpu if (!ref) { return 0; } - return (ref as any).getBoundingClientRect().width; + return ref.getBoundingClientRect().width; }; } |