aboutsummaryrefslogtreecommitdiffstats
path: root/packages/contract-wrappers/test/transaction_encoder_test.ts
diff options
context:
space:
mode:
authorJacob Evans <jacob@dekz.net>2018-09-26 13:41:49 +0800
committerJacob Evans <jacob@dekz.net>2018-09-28 07:59:58 +0800
commit21f60721863c974e0565009100891db53b7fb42c (patch)
tree26a7a26023e29b669c79ea4989af81ba1c84d6ec /packages/contract-wrappers/test/transaction_encoder_test.ts
parentbf3795d2acd377c6896bf3e825d43b8697a12f67 (diff)
downloaddexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.tar
dexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.tar.gz
dexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.tar.bz2
dexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.tar.lz
dexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.tar.xz
dexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.tar.zst
dexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.zip
Handle revert with reason when decoding call result
We use in-process ganache which throws on an RPC error. This means all of our tests get a nice revert error thrown when testing against ganache. This is not possible with RPC providers and a revert with reason result is returned. Our callAsync doesn't handle this and attempts to decode the revert with reason error log as a successful log, which results in an error while decoding. This only works with our fork of ethers https://github.com/ethers-io/ethers.js/pull/188 and will need to be re-worked when updating to Ethers.js 4
Diffstat (limited to 'packages/contract-wrappers/test/transaction_encoder_test.ts')
-rw-r--r--packages/contract-wrappers/test/transaction_encoder_test.ts2
1 files changed, 1 insertions, 1 deletions
diff --git a/packages/contract-wrappers/test/transaction_encoder_test.ts b/packages/contract-wrappers/test/transaction_encoder_test.ts
index e76c5b12d..a397e43a8 100644
--- a/packages/contract-wrappers/test/transaction_encoder_test.ts
+++ b/packages/contract-wrappers/test/transaction_encoder_test.ts
@@ -1,6 +1,6 @@
import { BlockchainLifecycle } from '@0xproject/dev-utils';
import { FillScenarios } from '@0xproject/fill-scenarios';
-import { assetDataUtils, signatureUtils, generatePseudoRandomSalt, orderHashUtils } from '@0xproject/order-utils';
+import { assetDataUtils, generatePseudoRandomSalt, orderHashUtils, signatureUtils } from '@0xproject/order-utils';
import { SignedOrder, SignerType } from '@0xproject/types';
import { BigNumber } from '@0xproject/utils';
import 'mocha';