Only send in amountAvailableToFill if it's a non-zero amount, add additional tests and nest, and put error into its own file

1 files changed, 7 insertions, 9 deletions

diff --git a/packages/asset-buyer/src/utils/buy_quote_calculator.ts b/packages/asset-buyer/src/utils/buy_quote_calculator.ts
index 23d3e9b24..59293d1b7 100644
--- a/packages/asset-buyer/src/utils/buy_quote_calculator.ts
+++ b/packages/asset-buyer/src/utils/buy_quote_calculator.ts
@@ -1,16 +1,10 @@
 import { marketUtils, SignedOrder } from '@0x/order-utils';
 import { BigNumber } from '@0x/utils';
-import { Web3Wrapper } from '@0x/web3-wrapper';
 import * as _ from 'lodash';
 
 import { constants } from '../constants';
-import {
-    AssetBuyerError,
-    BuyQuote,
-    BuyQuoteInfo,
-    InsufficientAssetLiquidityError,
-    OrdersAndFillableAmounts,
-} from '../types';
+import { InsufficientAssetLiquidityError } from '../errors';
+import { AssetBuyerError, BuyQuote, BuyQuoteInfo, OrdersAndFillableAmounts } from '../types';
 
 import { orderUtils } from './order_utils';
 
@@ -53,7 +47,11 @@ export const buyQuoteCalculator = {
                 .div(multiplerNeededWithSlippage)
                 .round(0, BigNumber.ROUND_DOWN);
 
-            throw new InsufficientAssetLiquidityError(amountAvailableToFillConsideringSlippage);
+            throw new InsufficientAssetLiquidityError(
+                amountAvailableToFillConsideringSlippage.gt(constants.ZERO_AMOUNT)
+                    ? amountAvailableToFillConsideringSlippage
+                    : undefined,
+            );
         }
         // if we are not buying ZRX:
         // given the orders calculated above, find the fee-orders that cover the desired assetBuyAmount (with slippage)