diff options
author | Steve Klebanoff <steve.klebanoff@gmail.com> | 2018-11-29 02:07:11 +0800 |
---|---|---|
committer | Steve Klebanoff <steve.klebanoff@gmail.com> | 2018-11-29 02:07:11 +0800 |
commit | ca894935f269a385f28e5d3a51720282ab403697 (patch) | |
tree | a2834b5b455baed8a9db01a018a7d5073b98d0c0 | |
parent | d3739488aed89ce98e805d48ec14a0d2608f85d7 (diff) | |
download | dexon-0x-contracts-ca894935f269a385f28e5d3a51720282ab403697.tar dexon-0x-contracts-ca894935f269a385f28e5d3a51720282ab403697.tar.gz dexon-0x-contracts-ca894935f269a385f28e5d3a51720282ab403697.tar.bz2 dexon-0x-contracts-ca894935f269a385f28e5d3a51720282ab403697.tar.lz dexon-0x-contracts-ca894935f269a385f28e5d3a51720282ab403697.tar.xz dexon-0x-contracts-ca894935f269a385f28e5d3a51720282ab403697.tar.zst dexon-0x-contracts-ca894935f269a385f28e5d3a51720282ab403697.zip |
Take out asset name and data as we can use the selected event properties
-rw-r--r-- | packages/instant/src/util/analytics.ts | 10 | ||||
-rw-r--r-- | packages/instant/src/util/buy_quote_updater.ts | 8 |
2 files changed, 2 insertions, 16 deletions
diff --git a/packages/instant/src/util/analytics.ts b/packages/instant/src/util/analytics.ts index dd6021453..b85c6cee2 100644 --- a/packages/instant/src/util/analytics.ts +++ b/packages/instant/src/util/analytics.ts @@ -185,17 +185,9 @@ export const analytics = { ...buyQuoteEventProperties(buyQuote), fetchedVia, }), - trackQuoteError: ( - errorMessage: string, - assetName: string, - assetData: string, - assetAmount: BigNumber, - fetchedVia: QuoteFetchedVia, - ) => { + trackQuoteError: (errorMessage: string, assetAmount: BigNumber, fetchedVia: QuoteFetchedVia) => { trackingEventFnWithPayload(EventNames.QUOTE_ERROR)({ errorMessage, - assetName, - assetData, assetAmount: assetAmount.toString(), fetchedVia, }); diff --git a/packages/instant/src/util/buy_quote_updater.ts b/packages/instant/src/util/buy_quote_updater.ts index 3c982ed1f..d6c4bd71b 100644 --- a/packages/instant/src/util/buy_quote_updater.ts +++ b/packages/instant/src/util/buy_quote_updater.ts @@ -37,13 +37,7 @@ export const buyQuoteUpdater = { } catch (error) { if (options.dispatchErrors) { dispatch(actions.setQuoteRequestStateFailure()); - analytics.trackQuoteError( - error.message ? error.message : 'other', - asset.metaData.name, - asset.assetData, - assetUnitAmount, - options.fetchedVia, - ); + analytics.trackQuoteError(error.message ? error.message : 'other', assetUnitAmount, options.fetchedVia); let errorMessage; if (error.message === AssetBuyerError.InsufficientAssetLiquidity) { const assetName = assetUtils.bestNameForAsset(asset, 'of this asset'); |