From 6658bea8d444281491718f8eee7bc3ae42f91b69 Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Thu, 21 Jul 2016 10:45:32 -0700 Subject: Implement some cross-browser practices (#473) * Add mozilla plugin key to manifest * Move all chrome references into platform-checking module Addresses #453 * Add chrome global back to linter blacklist * Add tests --- ui/app/components/transaction-list-item.js | 3 ++- ui/app/info.js | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) (limited to 'ui/app') diff --git a/ui/app/components/transaction-list-item.js b/ui/app/components/transaction-list-item.js index 78867fca4..796ba61ae 100644 --- a/ui/app/components/transaction-list-item.js +++ b/ui/app/components/transaction-list-item.js @@ -7,6 +7,7 @@ const addressSummary = require('../util').addressSummary const explorerLink = require('../../lib/explorer-link') const CopyButton = require('./copyButton') const vreme = new (require('vreme')) +const extension = require('../../../app/scripts/lib/extension') const TransactionIcon = require('./transaction-list-item-icon') @@ -49,7 +50,7 @@ TransactionListItem.prototype.render = function () { if (!transaction.hash || !isLinkable) return var url = explorerLink(transaction.hash, parseInt(network)) - chrome.tabs.create({ url }) + extension.tabs.create({ url }) }, style: { padding: '20px 0', diff --git a/ui/app/info.js b/ui/app/info.js index d97998fd7..4e540bd03 100644 --- a/ui/app/info.js +++ b/ui/app/info.js @@ -3,6 +3,7 @@ const Component = require('react').Component const h = require('react-hyperscript') const connect = require('react-redux').connect const actions = require('./actions') +const extension = require('../../app/scripts/lib/extension') module.exports = connect(mapStateToProps)(InfoScreen) @@ -19,7 +20,7 @@ InfoScreen.prototype.render = function () { var state = this.props var manifest try { - manifest = chrome.runtime.getManifest() + manifest = extension.runtime.getManifest() } catch (e) { manifest = { version: '2.0.0' } } @@ -105,7 +106,7 @@ InfoScreen.prototype.render = function () { h('a.info', { target: '_blank', style: { width: '85vw' }, - onClick () { chrome.tabs.create({url: 'mailto:help@metamask.io?subject=Feedback'}) }, + onClick () { extension.tabs.create({url: 'mailto:help@metamask.io?subject=Feedback'}) }, }, 'Email us any questions or comments!'), ]), @@ -124,5 +125,5 @@ InfoScreen.prototype.render = function () { } InfoScreen.prototype.navigateTo = function (url) { - chrome.tabs.create({ url }) + extension.tabs.create({ url }) } -- cgit v1.2.3