From c2046be0d8606ded9a328f392baf62cad802b98f Mon Sep 17 00:00:00 2001
From: Dan Finlay <dan@danfinlay.com>
Date: Wed, 30 Mar 2016 19:15:49 -0700
Subject: Made configuration migrateable

Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).

Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.

By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.

All the restructuring and data-type management is kept in one neat little place.

This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!

I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
---
 test/unit/config-manager-test.js | 71 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)
 create mode 100644 test/unit/config-manager-test.js

(limited to 'test/unit')

diff --git a/test/unit/config-manager-test.js b/test/unit/config-manager-test.js
new file mode 100644
index 000000000..10b6716d6
--- /dev/null
+++ b/test/unit/config-manager-test.js
@@ -0,0 +1,71 @@
+var assert = require('assert')
+var ConfigManager = require('../../app/scripts/lib/config-manager')
+var configManager
+
+describe('config-manager', function() {
+
+  before(function() {
+    window.localStorage = {} // Hacking localStorage support into JSDom
+    configManager = new ConfigManager()
+  })
+
+  describe('#setConfig', function() {
+    window.localStorage = {} // Hacking localStorage support into JSDom
+
+    it('should set the config key', function () {
+      var testConfig = {
+        provider: {
+          type: 'rpc',
+          rpcTarget: 'foobar'
+        }
+      }
+      configManager.setConfig(testConfig)
+      var result = configManager.getData()
+
+      assert.equal(result.config.provider.type, testConfig.provider.type)
+      assert.equal(result.config.provider.rpcTarget, testConfig.provider.rpcTarget)
+    })
+
+    it('setting wallet should not overwrite config', function() {
+      var testConfig = {
+        provider: {
+          type: 'rpc',
+          rpcTarget: 'foobar'
+        }
+      }
+      configManager.setConfig(testConfig)
+
+      var testWallet = {
+        name: 'this is my fake wallet'
+      }
+      configManager.setWallet(testWallet)
+
+      var result = configManager.getData()
+      assert.equal(result.wallet.name, testWallet.name, 'wallet name is set')
+      assert.equal(result.config.provider.rpcTarget, testConfig.provider.rpcTarget)
+
+      testConfig.provider.type = 'something else!'
+      configManager.setConfig(testConfig)
+
+      result = configManager.getData()
+      assert.equal(result.wallet.name, testWallet.name, 'wallet name is set')
+      assert.equal(result.config.provider.rpcTarget, testConfig.provider.rpcTarget)
+      assert.equal(result.config.provider.type, testConfig.provider.type)
+    })
+  })
+
+  describe('rpc manipulations', function() {
+    it('changing rpc should return a different rpc', function() {
+      var firstRpc = 'first'
+      var secondRpc = 'second'
+
+      configManager.setRpcTarget(firstRpc)
+      var firstResult = configManager.getCurrentRpcAddress()
+      assert.equal(firstResult, firstRpc)
+
+      configManager.setRpcTarget(secondRpc)
+      var secondResult = configManager.getCurrentRpcAddress()
+      assert.equal(secondResult, secondRpc)
+    })
+  })
+})
-- 
cgit v1.2.3