From 4a4736195f258c44723a87c659f6380d5dd2cfdd Mon Sep 17 00:00:00 2001
From: kumavis <aaron@kumavis.me>
Date: Tue, 8 Aug 2017 17:46:31 -0700
Subject: build - fix error swallowing on dev

---
 gulpfile.js | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

(limited to 'gulpfile.js')

diff --git a/gulpfile.js b/gulpfile.js
index cc723704a..57de37dd9 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -306,6 +306,17 @@ function bundleTask(opts) {
     return (
 
       bundler.bundle()
+
+      // handle errors
+      .on('error', (err) => {
+        beep()
+        if (opts.watch) {
+          console.warn(err.stack)
+        } else {
+          throw err
+        }
+      })
+      
       // convert bundle stream to gulp vinyl stream
       .pipe(source(opts.filename))
       // inject variables into bundle
@@ -314,7 +325,7 @@ function bundleTask(opts) {
       .pipe(buffer())
       // sourcemaps
       // loads map from browserify file
-      .pipe(gulpif(debug, sourcemaps.init({loadMaps: true})))
+      .pipe(gulpif(debug, sourcemaps.init({ loadMaps: true })))
       // writes .map file
       .pipe(gulpif(debug, sourcemaps.write('./')))
       // write completed bundles
@@ -328,3 +339,7 @@ function bundleTask(opts) {
     )
   }
 }
+
+function beep () {
+  process.stdout.write('\x07')
+}
-- 
cgit v1.2.3


From 59e83d2b8063e7ef7c57c1fe9a2cd9c846637e20 Mon Sep 17 00:00:00 2001
From: kumavis <aaron@kumavis.me>
Date: Tue, 8 Aug 2017 17:53:34 -0700
Subject: build - factor watcify into bundler generation

---
 gulpfile.js | 28 +++++++++++-----------------
 1 file changed, 11 insertions(+), 17 deletions(-)

(limited to 'gulpfile.js')

diff --git a/gulpfile.js b/gulpfile.js
index 57de37dd9..ac36cf983 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -248,26 +248,27 @@ function zipTask(target) {
   }
 }
 
-function generateBundler(opts) {
-  var browserifyOpts = assign({}, watchify.args, {
+function generateBundler(opts, performBundle) {
+  const browserifyOpts = assign({}, watchify.args, {
     entries: ['./app/scripts/'+opts.filename],
     plugin: 'browserify-derequire',
     debug: debug,
     fullPaths: debug,
   })
 
-  return browserify(browserifyOpts)
-}
-
-function discTask(opts) {
-  let bundler = generateBundler(opts)
+  let bundler = browserify(browserifyOpts)
 
   if (opts.watch) {
     bundler = watchify(bundler)
-    // on any dep update, runs the bundler
+    // on any file update, re-runs the bundler
     bundler.on('update', performBundle)
   }
 
+  return bundler
+}
+
+function discTask(opts) {
+  const bundler = generateBundler(opts, performBundle)
   // output build logs to terminal
   bundler.on('log', gutil.log)
 
@@ -289,14 +290,7 @@ function discTask(opts) {
 
 
 function bundleTask(opts) {
-  let bundler = generateBundler(opts)
-
-  if (opts.watch) {
-    bundler = watchify(bundler)
-    // on any file update, re-runs the bundler
-    bundler.on('update', performBundle)
-  }
-
+  const bundler = generateBundler(opts, performBundle)
   // output build logs to terminal
   bundler.on('log', gutil.log)
 
@@ -316,7 +310,7 @@ function bundleTask(opts) {
           throw err
         }
       })
-      
+
       // convert bundle stream to gulp vinyl stream
       .pipe(source(opts.filename))
       // inject variables into bundle
-- 
cgit v1.2.3