From 27cb02bc5868673af794e0ad597fea87b2ddf175 Mon Sep 17 00:00:00 2001 From: frankiebee Date: Wed, 12 Jul 2017 18:54:01 -0700 Subject: add "nonce too low" to the ignored errs list for tx retrys --- app/scripts/controllers/transactions.js | 1 + 1 file changed, 1 insertion(+) (limited to 'app') diff --git a/app/scripts/controllers/transactions.js b/app/scripts/controllers/transactions.js index 43735a691..4d037ce98 100644 --- a/app/scripts/controllers/transactions.js +++ b/app/scripts/controllers/transactions.js @@ -433,6 +433,7 @@ module.exports = class TransactionController extends EventEmitter { || errorMessage.includes('transaction with the same hash was already imported') // other || errorMessage.includes('gateway timeout') + || errorMessage.includes('nonce too low') ) // ignore resubmit warnings, return early if (isKnownTx) return -- cgit v1.2.3 From de0cd6e66375f690965f60c58e70900660f565f2 Mon Sep 17 00:00:00 2001 From: frankiebee Date: Wed, 12 Jul 2017 18:56:50 -0700 Subject: write a migration for resubmit tx's to get put back into a submitted state --- app/scripts/migrations/017.js | 40 ++++++++++++++++++++++++++++++++++++++++ app/scripts/migrations/index.js | 1 + 2 files changed, 41 insertions(+) create mode 100644 app/scripts/migrations/017.js (limited to 'app') diff --git a/app/scripts/migrations/017.js b/app/scripts/migrations/017.js new file mode 100644 index 000000000..c9898ead7 --- /dev/null +++ b/app/scripts/migrations/017.js @@ -0,0 +1,40 @@ +const version = 17 + +/* + +This migration sets transactions who were retried and marked as failed to submitted + +*/ + +const clone = require('clone') + +module.exports = { + version, + + migrate: function (originalVersionedData) { + const versionedData = clone(originalVersionedData) + versionedData.meta.version = version + try { + const state = versionedData.data + const newState = transformState(state) + versionedData.data = newState + } catch (err) { + console.warn(`MetaMask Migration #${version}` + err.stack) + } + return Promise.resolve(versionedData) + }, +} + +function transformState (state) { + const newState = state + const transactions = newState.TransactionController.transactions + newState.TransactionController.transactions = transactions.map((txMeta) => { + if (!txMeta.status === 'failed') return txMeta + if (txMeta.retryCount > 0) { + txMeta.status = 'submitted' + delete txMeta.err + } + return txMeta + }) + return newState +} diff --git a/app/scripts/migrations/index.js b/app/scripts/migrations/index.js index a4f9c7c4d..f4c87499f 100644 --- a/app/scripts/migrations/index.js +++ b/app/scripts/migrations/index.js @@ -27,4 +27,5 @@ module.exports = [ require('./014'), require('./015'), require('./016'), + require('./017'), ] -- cgit v1.2.3 From 6086bcdf0d1346633bc41fde88bb315ead7f9227 Mon Sep 17 00:00:00 2001 From: frankiebee Date: Wed, 12 Jul 2017 20:01:07 -0700 Subject: limit the range for retryCount --- app/scripts/migrations/017.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app') diff --git a/app/scripts/migrations/017.js b/app/scripts/migrations/017.js index c9898ead7..24959cd3a 100644 --- a/app/scripts/migrations/017.js +++ b/app/scripts/migrations/017.js @@ -30,7 +30,7 @@ function transformState (state) { const transactions = newState.TransactionController.transactions newState.TransactionController.transactions = transactions.map((txMeta) => { if (!txMeta.status === 'failed') return txMeta - if (txMeta.retryCount > 0) { + if (txMeta.retryCount > 0 && txMeta.retryCount < 2) { txMeta.status = 'submitted' delete txMeta.err } -- cgit v1.2.3