From 70a61f8712db89687db5df99275a71e018d1e430 Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Tue, 5 Sep 2017 11:35:33 -0700 Subject: Make web3 deprecation notice more useful Linking to a descriptive & precriptive article on a path forward. --- CHANGELOG.md | 1 + app/scripts/lib/auto-reload.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e6835e7bc..d9cb02a24 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ - Add the total amount of tokens when multiple tokens are added under the token list - Use HTTPS links for Etherscan. - Update Support center link to new one with HTTPS. +- Make web3 deprecation notice more useful by linking to a descriptive article. ## 3.9.11 2017-8-24 diff --git a/app/scripts/lib/auto-reload.js b/app/scripts/lib/auto-reload.js index 62aaf405c..cce31c3d2 100644 --- a/app/scripts/lib/auto-reload.js +++ b/app/scripts/lib/auto-reload.js @@ -11,7 +11,7 @@ function setupDappAutoReload (web3, observable) { get: (_web3, key) => { // show warning once on web3 access if (!hasBeenWarned && key !== 'currentProvider') { - console.warn('MetaMask: web3 will be deprecated in the near future in favor of the ethereumProvider \nhttps://github.com/ethereum/mist/releases/tag/v0.9.0') + console.warn('MetaMask: web3 will be deprecated in the near future in favor of the ethereumProvider \nhttps://github.com/MetaMask/faq/blob/master/detecting_metamask.md#web3-deprecation') hasBeenWarned = true } // get the time of use -- cgit v1.2.3 From 90272e252fa265037ecdfb3f618aa1a8e16ee4fb Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Tue, 5 Sep 2017 11:44:26 -0700 Subject: Make eth_sign deprecation warning more useful Link to descriptive article that demonstrates the new preferred method. --- CHANGELOG.md | 1 + ui/app/components/pending-msg.js | 15 +++++++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e6835e7bc..f82f77a4e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## Current Master - Make eth_sign deprecation warning less noisy +- Add useful link to eth_sign deprecation warning. - Fix bug with network version serialization over synchronous RPC - Add MetaMask version to state logs. - Add the total amount of tokens when multiple tokens are added under the token list diff --git a/ui/app/components/pending-msg.js b/ui/app/components/pending-msg.js index b7133cda8..834719c53 100644 --- a/ui/app/components/pending-msg.js +++ b/ui/app/components/pending-msg.js @@ -35,10 +35,21 @@ PendingMsg.prototype.render = function () { style: { margin: '10px', }, - }, `Signing this message can have + }, [ + `Signing this message can have dangerous side effects. Only sign messages from sites you fully trust with your entire account. - This dangerous method will be removed in a future version.`), + This dangerous method will be removed in a future version. `, + h('a', { + href: 'https://medium.com/metamask/the-new-secure-way-to-sign-data-in-your-browser-6af9dd2a1527', + style: { color: 'rgb(247, 134, 28)' }, + onClick: (event) => { + event.preventDefault() + const url = 'https://medium.com/metamask/the-new-secure-way-to-sign-data-in-your-browser-6af9dd2a1527' + global.platform.openWindow({ url }) + }, + }, 'Read more here.'), + ]), // message details h(PendingTxDetails, state), -- cgit v1.2.3